[PATCH] osmo-iuh[master]: cs RAB: tweak sDU_ErrorRatio

Neels Hofmeyr gerrit-no-reply at lists.osmocom.org
Wed Feb 1 13:10:38 UTC 2017


Hello Jenkins Builder,

I'd like you to reexamine a change.  Please visit

    https://gerrit.osmocom.org/1644

to look at the new patch set (#2).

cs RAB: tweak sDU_ErrorRatio

This is mimicking the IEs found in a trace from a production 3G environment. We
have no reason to add this other than knowing that other operators seem to do
this.

This came up while trying to fix voice RAB for the nano3G, but this patch had
no effect on that. Now that it's here, we might as well keep it.

Change-Id: I3169376bb182aba5926b7c974108bdc5fba04fa4
---
M src/ranap_msg_factory.c
M src/tests/test-ranap.ok
2 files changed, 4 insertions(+), 4 deletions(-)


  git pull ssh://gerrit.osmocom.org:29418/osmo-iuh refs/changes/44/1644/2

diff --git a/src/ranap_msg_factory.c b/src/ranap_msg_factory.c
index 36a39c2..89ffffb 100644
--- a/src/ranap_msg_factory.c
+++ b/src/ranap_msg_factory.c
@@ -487,7 +487,7 @@
 
 	switch (profile) {
 	case SDUPAR_P_VOICE0:
-		sdui->sDU_ErrorRatio = new_sdu_error_ratio(1, 5);
+		sdui->sDU_ErrorRatio = new_sdu_error_ratio(7, 3);
 		sdui->residualBitErrorRatio.mantissa = 1;
 		sdui->residualBitErrorRatio.exponent = 6;
 		sdui->deliveryOfErroneousSDU = RANAP_DeliveryOfErroneousSDU_yes;
diff --git a/src/tests/test-ranap.ok b/src/tests/test-ranap.ok
index fdff38f..0ab99b0 100644
--- a/src/tests/test-ranap.ok
+++ b/src/tests/test-ranap.ok
@@ -88,7 +88,7 @@
     <id>53</id>
     <firstCriticality><reject/></firstCriticality>
     <firstValue>
-        78 02 CD 80 10 2F A7 20 1A 2C 00 00 F4 4C 08 0A 
+        78 02 CD 80 10 2F A7 20 1A 2C 00 00 F4 4C 64 0A 
         02 80 00 51 40 00 27 20 28 14 00 67 40 00 00 22 
         28 14 00 3C 40 00 00 00 50 3D 02 00 02 0D C0 35 
         00 01 0A 0B 0C 0D 40 09 26 00 00
@@ -101,13 +101,13 @@
     <criticality><ignore/></criticality>
     <value>
         00 00 01 00 35 00 3B 78 02 CD 80 10 2F A7 20 1A 
-        2C 00 00 F4 4C 08 0A 02 80 00 51 40 00 27 20 28 
+        2C 00 00 F4 4C 64 0A 02 80 00 51 40 00 27 20 28 
         14 00 67 40 00 00 22 28 14 00 3C 40 00 00 00 50 
         3D 02 00 02 0D C0 35 00 01 0A 0B 0C 0D 40 09 26 
         00 00 40 01 00
     </value>
 </RANAP_IE>
-00 00 00 4c 00 00 01 00 36 40 45 00 00 01 00 35 00 3b 78 02 cd 80 10 2f a7 20 1a 2c 00 00 f4 4c 08 0a 02 80 00 51 40 00 27 20 28 14 00 67 40 00 00 22 28 14 00 3c 40 00 00 00 50 3d 02 00 02 0d c0 35 00 01 0a 0b 0c 0d 40 09 26 00 00 40 01 00 
+00 00 00 4c 00 00 01 00 36 40 45 00 00 01 00 35 00 3b 78 02 cd 80 10 2f a7 20 1a 2c 00 00 f4 4c 64 0a 02 80 00 51 40 00 27 20 28 14 00 67 40 00 00 22 28 14 00 3c 40 00 00 00 50 3d 02 00 02 0d c0 35 00 01 0a 0b 0c 0d 40 09 26 00 00 40 01 00 
 
 ==> RAB ASSIGNMENT COMMAND (DATA)
 <RANAP_ProtocolIE-FieldPair>

-- 
To view, visit https://gerrit.osmocom.org/1644
To unsubscribe, visit https://gerrit.osmocom.org/settings

Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I3169376bb182aba5926b7c974108bdc5fba04fa4
Gerrit-PatchSet: 2
Gerrit-Project: osmo-iuh
Gerrit-Branch: master
Gerrit-Owner: Neels Hofmeyr <nhofmeyr at sysmocom.de>
Gerrit-Reviewer: Holger Freyther <holger at freyther.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: Neels Hofmeyr <nhofmeyr at sysmocom.de>


More information about the gerrit-log mailing list