[PATCH] osmo-iuh[master]: cs RAB: add more SDU_FormatInformationParameter items

Neels Hofmeyr gerrit-no-reply at lists.osmocom.org
Wed Feb 1 13:10:38 UTC 2017


Hello Jenkins Builder, Holger Freyther,

I'd like you to reexamine a change.  Please visit

    https://gerrit.osmocom.org/1649

to look at the new patch set (#2).

cs RAB: add more SDU_FormatInformationParameter items

This is mimicking the IEs found in a trace from a production 3G environment. We
have no reason to add this other than knowing that other operators seem to do
this.

This came up while trying to fix voice RAB for the nano3G, but this patch had
no effect on that. Now that it's here, we might as well keep it.

Change-Id: I97e5c0b1e9ab9de00449b50a86d79a967af0d3f3
---
M src/ranap_msg_factory.c
M src/tests/test-ranap.ok
2 files changed, 39 insertions(+), 11 deletions(-)


  git pull ssh://gerrit.osmocom.org:29418/osmo-iuh refs/changes/49/1649/2

diff --git a/src/ranap_msg_factory.c b/src/ranap_msg_factory.c
index dc5ba08..87d646b 100644
--- a/src/ranap_msg_factory.c
+++ b/src/ranap_msg_factory.c
@@ -494,6 +494,14 @@
 		sdui->sDU_FormatInformationParameters = fmtip;
 		fmti = new_format_info_pars(81);
 		ASN_SEQUENCE_ADD(fmtip, fmti);
+		fmti = new_format_info_pars(65);
+		ASN_SEQUENCE_ADD(fmtip, fmti);
+		fmti = new_format_info_pars(75);
+		ASN_SEQUENCE_ADD(fmtip, fmti);
+		fmti = new_format_info_pars(61);
+		ASN_SEQUENCE_ADD(fmtip, fmti);
+		fmti = new_format_info_pars(57);
+		ASN_SEQUENCE_ADD(fmtip, fmti);
 		fmti = new_format_info_pars(39);
 		ASN_SEQUENCE_ADD(fmtip, fmti);
 		/* FIXME: could be 10 SDU descriptors for AMR! */
@@ -505,6 +513,14 @@
 		sdui->sDU_FormatInformationParameters = fmtip;
 		fmti = new_format_info_pars(103);
 		ASN_SEQUENCE_ADD(fmtip, fmti);
+		fmti = new_format_info_pars(99);
+		ASN_SEQUENCE_ADD(fmtip, fmti);
+		fmti = new_format_info_pars(84);
+		ASN_SEQUENCE_ADD(fmtip, fmti);
+		fmti = new_format_info_pars(87);
+		ASN_SEQUENCE_ADD(fmtip, fmti);
+		fmti = new_format_info_pars(76);
+		ASN_SEQUENCE_ADD(fmtip, fmti);
 		fmti = new_format_info_pars(0);
 		ASN_SEQUENCE_ADD(fmtip, fmti);
 		/* FIXME: could be 10 SDU descriptors for AMR! */
@@ -516,6 +532,14 @@
 		sdui->sDU_FormatInformationParameters = fmtip;
 		fmti = new_format_info_pars(60);
 		ASN_SEQUENCE_ADD(fmtip, fmti);
+		fmti = new_format_info_pars(40);
+		ASN_SEQUENCE_ADD(fmtip, fmti);
+		fmti = new_format_info_pars(0);
+		ASN_SEQUENCE_ADD(fmtip, fmti);
+		fmti = new_format_info_pars(0);
+		ASN_SEQUENCE_ADD(fmtip, fmti);
+		fmti = new_format_info_pars(0);
+		ASN_SEQUENCE_ADD(fmtip, fmti);
 		fmti = new_format_info_pars(0);
 		ASN_SEQUENCE_ADD(fmtip, fmti);
 		/* FIXME: could be 10 SDU descriptors for AMR! */
diff --git a/src/tests/test-ranap.ok b/src/tests/test-ranap.ok
index 8771113..99d34ee 100644
--- a/src/tests/test-ranap.ok
+++ b/src/tests/test-ranap.ok
@@ -89,10 +89,12 @@
     <firstCriticality><reject/></firstCriticality>
     <firstValue>
         78 02 CD 80 10 2F A7 20 1A 2C 00 00 F4 4C 64 0A 
-        02 80 00 51 40 00 27 20 28 14 00 67 40 00 00 22 
-        28 14 00 3C 40 00 00 00 50 38 82 00 02 27 C0 35 
-        00 01 0A 0B 0C 0D 00 00 00 00 00 00 00 00 00 00 
-        00 00 00 40 09 26 00 00
+        0A 80 00 51 40 00 41 40 00 4B 40 00 3D 40 00 39 
+        40 00 27 20 28 54 00 67 40 00 63 40 00 54 40 00 
+        57 40 00 4C 40 00 00 22 28 54 00 3C 40 00 28 40 
+        00 00 40 00 00 40 00 00 40 00 00 00 50 38 82 00 
+        02 27 C0 35 00 01 0A 0B 0C 0D 00 00 00 00 00 00 
+        00 00 00 00 00 00 00 40 09 26 00 00
     </firstValue>
     <secondCriticality><ignore/></secondCriticality>
     <secondValue>00</secondValue>
@@ -101,15 +103,17 @@
     <id>54</id>
     <criticality><ignore/></criticality>
     <value>
-        00 00 01 00 35 00 48 78 02 CD 80 10 2F A7 20 1A 
-        2C 00 00 F4 4C 64 0A 02 80 00 51 40 00 27 20 28 
-        14 00 67 40 00 00 22 28 14 00 3C 40 00 00 00 50 
-        38 82 00 02 27 C0 35 00 01 0A 0B 0C 0D 00 00 00 
-        00 00 00 00 00 00 00 00 00 00 40 09 26 00 00 40 
-        01 00
+        00 00 01 00 35 00 6C 78 02 CD 80 10 2F A7 20 1A 
+        2C 00 00 F4 4C 64 0A 0A 80 00 51 40 00 41 40 00 
+        4B 40 00 3D 40 00 39 40 00 27 20 28 54 00 67 40 
+        00 63 40 00 54 40 00 57 40 00 4C 40 00 00 22 28 
+        54 00 3C 40 00 28 40 00 00 40 00 00 40 00 00 40 
+        00 00 00 50 38 82 00 02 27 C0 35 00 01 0A 0B 0C 
+        0D 00 00 00 00 00 00 00 00 00 00 00 00 00 40 09 
+        26 00 00 40 01 00
     </value>
 </RANAP_IE>
-00 00 00 59 00 00 01 00 36 40 52 00 00 01 00 35 00 48 78 02 cd 80 10 2f a7 20 1a 2c 00 00 f4 4c 64 0a 02 80 00 51 40 00 27 20 28 14 00 67 40 00 00 22 28 14 00 3c 40 00 00 00 50 38 82 00 02 27 c0 35 00 01 0a 0b 0c 0d 00 00 00 00 00 00 00 00 00 00 00 00 00 40 09 26 00 00 40 01 00 
+00 00 00 7d 00 00 01 00 36 40 76 00 00 01 00 35 00 6c 78 02 cd 80 10 2f a7 20 1a 2c 00 00 f4 4c 64 0a 0a 80 00 51 40 00 41 40 00 4b 40 00 3d 40 00 39 40 00 27 20 28 54 00 67 40 00 63 40 00 54 40 00 57 40 00 4c 40 00 00 22 28 54 00 3c 40 00 28 40 00 00 40 00 00 40 00 00 40 00 00 00 50 38 82 00 02 27 c0 35 00 01 0a 0b 0c 0d 00 00 00 00 00 00 00 00 00 00 00 00 00 40 09 26 00 00 40 01 00 
 
 ==> RAB ASSIGNMENT COMMAND (DATA)
 <RANAP_ProtocolIE-FieldPair>

-- 
To view, visit https://gerrit.osmocom.org/1649
To unsubscribe, visit https://gerrit.osmocom.org/settings

Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I97e5c0b1e9ab9de00449b50a86d79a967af0d3f3
Gerrit-PatchSet: 2
Gerrit-Project: osmo-iuh
Gerrit-Branch: master
Gerrit-Owner: Neels Hofmeyr <nhofmeyr at sysmocom.de>
Gerrit-Reviewer: Holger Freyther <holger at freyther.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: Max <msuraev at sysmocom.de>
Gerrit-Reviewer: Neels Hofmeyr <nhofmeyr at sysmocom.de>


More information about the gerrit-log mailing list