openbsc[master]: SGSN: Integrate basic support for UMTS AKA

Neels Hofmeyr gerrit-no-reply at lists.osmocom.org
Wed Feb 1 04:03:20 UTC 2017


Patch Set 4:

(2 comments)

> What about the TODO? AUTS and GSUP for the authentication failure
 > seem important?

Right ... oversaw that (since it's a commit by Harald originally)

https://gerrit.osmocom.org/#/c/1683/4/openbsc/src/gprs/gprs_gmm.c
File openbsc/src/gprs/gprs_gmm.c:

Line 537: 	else
> Skip this else?
yes


Line 714: 		LOGMMCTXP(LOGL_NOTICE, ctx, "Mismatch: expected SRES = %s\n",
> I think we print both things we compare to aid troubleshooting.
osmo_hexdump works only once per va_args, and the received SRES is printed above as DEBUG log. This patch only clarifies the wording without changing that semantic.


-- 
To view, visit https://gerrit.osmocom.org/1683
To unsubscribe, visit https://gerrit.osmocom.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ie6a0cefba5e4e7f02cc2eaf6ec006ac07d5c1816
Gerrit-PatchSet: 4
Gerrit-Project: openbsc
Gerrit-Branch: master
Gerrit-Owner: Neels Hofmeyr <nhofmeyr at sysmocom.de>
Gerrit-Reviewer: Holger Freyther <holger at freyther.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: Max <msuraev at sysmocom.de>
Gerrit-Reviewer: Neels Hofmeyr <nhofmeyr at sysmocom.de>
Gerrit-HasComments: Yes


More information about the gerrit-log mailing list