openbsc[master]: log: disable imsi filter

Neels Hofmeyr gerrit-no-reply at lists.osmocom.org
Wed Feb 1 03:17:07 UTC 2017


Patch Set 3:

The FSM logging isn't really an apt replacement for the IMSI filter. I'm still thinking about this ... how to achieve IMSI log filtering with two (three?) kinds of {bsc,vlr,gprs}_subscriber structs?

I had one idea where we set a log level on a vlr_subscriber and provide a LOG_VSUB(vsub, subsys, level, ...) that we try to use everywhere where a subscriber is involved. That would mean to edit most of the logging lines we have though. The previous filter concept of setting a context for each select() seems niftier. But does it work well?

-- 
To view, visit https://gerrit.osmocom.org/1685
To unsubscribe, visit https://gerrit.osmocom.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ifecc3c55ae7c050ee53553d6f85d9afbede66ee3
Gerrit-PatchSet: 3
Gerrit-Project: openbsc
Gerrit-Branch: master
Gerrit-Owner: Neels Hofmeyr <nhofmeyr at sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: Neels Hofmeyr <nhofmeyr at sysmocom.de>
Gerrit-HasComments: No


More information about the gerrit-log mailing list