[MERGED] osmo-bsc[master]: Fix .deb builds

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

Harald Welte gerrit-no-reply at lists.osmocom.org
Sat Dec 30 19:50:28 UTC 2017


Harald Welte has submitted this change and it was merged.

Change subject: Fix .deb builds
......................................................................


Fix .deb builds

The code triggers following error:
abisip-find.c:317:3: error: format not a string literal and no format
arguments [-Werror=format-security]

The error was introduced in 5bf1e15c55340f236d84f70d3d04c871403d3503.

Change-Id: I613781495edbc53916ca70ff7b78d28ffabd3f5d
---
M src/ipaccess/abisip-find.c
1 file changed, 2 insertions(+), 6 deletions(-)

Approvals:
  Harald Welte: Looks good to me, approved
  Jenkins Builder: Verified



diff --git a/src/ipaccess/abisip-find.c b/src/ipaccess/abisip-find.c
index d94e18a..4e1d192 100644
--- a/src/ipaccess/abisip-find.c
+++ b/src/ipaccess/abisip-find.c
@@ -312,12 +312,8 @@
 		base_stations_bump(changed);
 		printf("RX: %u   \r", responses);
 		fflush(stdout);
-	} else {
-		char *line = parse_response(ctx, buf, len);
-		printf(line);
-		printf("\n");
-		talloc_free(line);
-	}
+	} else
+		printf("%s\n", parse_response(ctx, buf, len));
 }
 
 static int read_response(int fd)

-- 
To view, visit https://gerrit.osmocom.org/5619
To unsubscribe, visit https://gerrit.osmocom.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I613781495edbc53916ca70ff7b78d28ffabd3f5d
Gerrit-PatchSet: 1
Gerrit-Project: osmo-bsc
Gerrit-Branch: master
Gerrit-Owner: Max <msuraev at sysmocom.de>
Gerrit-Reviewer: Harald Welte <laforge at gnumonks.org>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: Neels Hofmeyr <nhofmeyr at sysmocom.de>



More information about the gerrit-log mailing list