meta-telephony[201705]: libdbi: Add version 0.9.0 to fix osmo-msc build failure

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

Pau Espin Pedrol gerrit-no-reply at lists.osmocom.org
Fri Dec 29 19:14:59 UTC 2017


Patch Set 1:

(4 comments)

Please, provide another patch to remove older versions of libdbi recipes in the same directory, as we don't need them anymore.

Make sure you build-tested the patch and add the Verfied+1 mark. If libdbi-drviers tests are disabled, we should look at the details and then check that osmo-msc still works after using the new libdbi.

https://gerrit.osmocom.org/#/c/5618/1//COMMIT_MSG
Commit Message:

Line 7: libdbi: Add version 0.9.0 to fix osmo-msc build failure
You can specify the commit since the build failure started: c22e54deabebd4c7ed45683b2db4c61afac7e1b9.


https://gerrit.osmocom.org/#/c/5618/1/recipes-misc/libdbi/files/fix-0.9.0-compile.patch
File recipes-misc/libdbi/files/fix-0.9.0-compile.patch:

Line 8: +		SQLITE3_LIBS=-lsqlite3
Please provide somewhere a reference explaining that this is a backport coming from libdbi-drviers 29ea4fd2c00a3c39ab4de08e3f333d5f4e219569, which should be available after a version newer than 0.9 is available, meaning we can drop this patch at that point.
Even better, use format-patch for that commit and use it instead of this file.


Line 19: +SUBDIRS = drivers @docs_subdirs@
Why is this needed? why are the tests failing? I see no reference to this in the commit description. Please provide one.


https://gerrit.osmocom.org/#/c/5618/1/recipes-misc/libdbi/libdbi-drivers_0.9.0.bb
File recipes-misc/libdbi/libdbi-drivers_0.9.0.bb:

Line 8: SRC_URI += "file://fix-0.9.0-compile.patch"
If not available in the file output from format-patch, you may want to specify the origin of the patch here as a comment.


-- 
To view, visit https://gerrit.osmocom.org/5618
To unsubscribe, visit https://gerrit.osmocom.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ia4319c595a1ccb20c87d86c1ab1e58e95da34d7b
Gerrit-PatchSet: 1
Gerrit-Project: meta-telephony
Gerrit-Branch: 201705
Gerrit-Owner: daniel <dwillmann at sysmocom.de>
Gerrit-Reviewer: Harald Welte <laforge at gnumonks.org>
Gerrit-Reviewer: Pau Espin Pedrol <pespin at sysmocom.de>
Gerrit-HasComments: Yes



More information about the gerrit-log mailing list