[MERGED] osmo-ttcn3-hacks[master]: MGCP_Test: Test use of 30 endpoint numbers

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

Harald Welte gerrit-no-reply at lists.osmocom.org
Thu Dec 28 02:41:32 UTC 2017


Harald Welte has submitted this change and it was merged.

Change subject: MGCP_Test: Test use of 30 endpoint numbers
......................................................................


MGCP_Test: Test use of 30 endpoint numbers

We used to have a big (OS#2784) where only endpoint numbers below
10 (0x0A) were working due to failed interpretation in hex/dec.

Let's use up to 30 endpoints to ensure hex as well as two-digit
digit numbers.

Change-Id: Ifb3e01b5d31decefbf0c87ea39ec5021c8795579
---
M mgw/MGCP_Test.ttcn
1 file changed, 26 insertions(+), 0 deletions(-)

Approvals:
  Harald Welte: Looks good to me, approved
  Jenkins Builder: Verified



diff --git a/mgw/MGCP_Test.ttcn b/mgw/MGCP_Test.ttcn
index 80f4c83..3a548c4 100644
--- a/mgw/MGCP_Test.ttcn
+++ b/mgw/MGCP_Test.ttcn
@@ -452,6 +452,32 @@
 		setverdict(pass);
 	}
 
+	function f_crcx_and_dlcx_ep_callid_connid(MgcpEndpoint ep, MgcpCallId call_id) runs on dummy_CT {
+		var template MgcpCommand cmd;
+		var MgcpResponse resp;
+
+		cmd := ts_CRCX(get_next_trans_id(), ep, "recvonly", call_id);
+		resp := mgcp_transceive_mgw(cmd, tr_CRCX_ACK);
+
+		f_dlcx_ok(ep, call_id, extract_conn_id(resp));
+
+		setverdict(pass);
+	}
+
+	testcase TC_crcx_dlcx_30ep() runs on dummy_CT {
+		var MgcpEndpoint ep;
+		var MgcpCallId call_id;
+		var integer ep_nr;
+
+		f_init();
+
+		for (ep_nr := 1; ep_nr < 30; ep_nr := ep_nr+1) {
+			ep := hex2str(int2hex(ep_nr, 2)) & "@mgw";
+			call_id := int2hex(ep_nr, 2) & '1234'H;
+			f_crcx_and_dlcx_ep_callid_connid(ep, call_id);
+		}
+	}
+
 	/* Test (valid) CRCX followed by (valid) DLCX containing EP+CallId */
 	testcase TC_crcx_and_dlcx_ep_callid() runs on dummy_CT {
 		var template MgcpCommand cmd;

-- 
To view, visit https://gerrit.osmocom.org/5601
To unsubscribe, visit https://gerrit.osmocom.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: Ifb3e01b5d31decefbf0c87ea39ec5021c8795579
Gerrit-PatchSet: 1
Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-Owner: Harald Welte <laforge at gnumonks.org>
Gerrit-Reviewer: Harald Welte <laforge at gnumonks.org>
Gerrit-Reviewer: Jenkins Builder



More information about the gerrit-log mailing list