This is merely a historical archive of years 2008-2021, before the migration to mailman3.
A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.
Harald Welte gerrit-no-reply at lists.osmocom.orgHarald Welte has submitted this change and it was merged. Change subject: mgcp_msg: We must parse endpoint numbers as hex, not decimal! ...................................................................... mgcp_msg: We must parse endpoint numbers as hex, not decimal! The MGCP client uses hex numbers, while the server side parses it as decimal. This results in the first 10 calls succeeding, but from 0x0a onwards it of course fails :/ Change-Id: I006f5f5325f0a5069d02fec8912a38d943cfc552 Closes: OS#2784 --- M src/libosmo-mgcp/mgcp_msg.c 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Harald Welte: Looks good to me, approved Jenkins Builder: Verified diff --git a/src/libosmo-mgcp/mgcp_msg.c b/src/libosmo-mgcp/mgcp_msg.c index 17b1026..d6174df 100644 --- a/src/libosmo-mgcp/mgcp_msg.c +++ b/src/libosmo-mgcp/mgcp_msg.c @@ -192,7 +192,7 @@ if (strncmp(mgcp, "ds/e1", 5) == 0) return find_e1_endpoint(cfg, mgcp); - gw = strtoul(mgcp, &endptr, 10); + gw = strtoul(mgcp, &endptr, 16); if (gw > 0 && gw < cfg->trunk.number_endpoints && endptr[0] == '@') return &cfg->trunk.endpoints[gw]; -- To view, visit https://gerrit.osmocom.org/5600 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I006f5f5325f0a5069d02fec8912a38d943cfc552 Gerrit-PatchSet: 1 Gerrit-Project: osmo-mgw Gerrit-Branch: master Gerrit-Owner: Harald Welte <laforge at gnumonks.org> Gerrit-Reviewer: Harald Welte <laforge at gnumonks.org> Gerrit-Reviewer: Jenkins Builder