osmo-pcu[master]: cosmetic: clarify coding scheme and puncturing

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

Harald Welte gerrit-no-reply at lists.osmocom.org
Thu Dec 21 11:38:28 UTC 2017


Patch Set 1:

(1 comment)

https://gerrit.osmocom.org/#/c/5535/1/src/gprs_coding_scheme.h
File src/gprs_coding_scheme.h:

Line 94: 	uint8_t sizeUL() const;
I don't understand what we gain by all those conversions?  What's the benefit?  I can only see the problem of creating more clashes with other patches :/


-- 
To view, visit https://gerrit.osmocom.org/5535
To unsubscribe, visit https://gerrit.osmocom.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: If599a6c8a6ef56d847604fcf41bb71decccd8a78
Gerrit-PatchSet: 1
Gerrit-Project: osmo-pcu
Gerrit-Branch: master
Gerrit-Owner: Max <msuraev at sysmocom.de>
Gerrit-Reviewer: Harald Welte <laforge at gnumonks.org>
Gerrit-Reviewer: Jenkins Builder
Gerrit-HasComments: Yes



More information about the gerrit-log mailing list