[MERGED] osmo-sgsn[master]: Replace '.' in counter names with ':'

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

Max gerrit-no-reply at lists.osmocom.org
Wed Dec 20 16:52:03 UTC 2017


Max has submitted this change and it was merged.

Change subject: Replace '.' in counter names with ':'
......................................................................


Replace '.' in counter names with ':'

The '.' is illegal character in counter names, as they are exported
via CTRL interface, where '.' has a special meaning that cannot be
used by strings comprising the variable name.

Change-Id: I4eb6851d3577f5942ae1a9ab28d3b3ca7ab8e208
---
M src/gprs/gb_proxy.c
M src/gprs/gb_proxy_peer.c
M src/gprs/gtphub.c
3 files changed, 3 insertions(+), 3 deletions(-)

Approvals:
  Harald Welte: Looks good to me, approved
  Jenkins Builder: Verified



diff --git a/src/gprs/gb_proxy.c b/src/gprs/gb_proxy.c
index 17a0109..6a9bc22 100644
--- a/src/gprs/gb_proxy.c
+++ b/src/gprs/gb_proxy.c
@@ -70,7 +70,7 @@
 };
 
 static const struct rate_ctr_group_desc global_ctrg_desc = {
-	.group_name_prefix = "gbproxy.global",
+	.group_name_prefix = "gbproxy:global",
 	.group_description = "GBProxy Global Statistics",
 	.num_ctr = ARRAY_SIZE(global_ctr_description),
 	.ctr_desc = global_ctr_description,
diff --git a/src/gprs/gb_proxy_peer.c b/src/gprs/gb_proxy_peer.c
index 69cce3a..f2cdd93 100644
--- a/src/gprs/gb_proxy_peer.c
+++ b/src/gprs/gb_proxy_peer.c
@@ -73,7 +73,7 @@
 osmo_static_assert(ARRAY_SIZE(peer_ctr_description) == GBPROX_PEER_CTR_LAST, everything_described);
 
 static const struct rate_ctr_group_desc peer_ctrg_desc = {
-	.group_name_prefix = "gbproxy.peer",
+	.group_name_prefix = "gbproxy:peer",
 	.group_description = "GBProxy Peer Statistics",
 	.num_ctr = ARRAY_SIZE(peer_ctr_description),
 	.ctr_desc = peer_ctr_description,
diff --git a/src/gprs/gtphub.c b/src/gprs/gtphub.c
index 7e3e663..5e962f2 100644
--- a/src/gprs/gtphub.c
+++ b/src/gprs/gtphub.c
@@ -125,7 +125,7 @@
 };
 
 static const struct rate_ctr_group_desc gtphub_ctrg_io_desc = {
-	.group_name_prefix = "gtphub.bind",
+	.group_name_prefix = "gtphub:bind",
 	.group_description = "I/O Statistics",
 	.num_ctr = ARRAY_SIZE(gtphub_counters_io_desc),
 	.ctr_desc = gtphub_counters_io_desc,

-- 
To view, visit https://gerrit.osmocom.org/5525
To unsubscribe, visit https://gerrit.osmocom.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I4eb6851d3577f5942ae1a9ab28d3b3ca7ab8e208
Gerrit-PatchSet: 4
Gerrit-Project: osmo-sgsn
Gerrit-Branch: master
Gerrit-Owner: Max <msuraev at sysmocom.de>
Gerrit-Reviewer: Harald Welte <laforge at gnumonks.org>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: Max <msuraev at sysmocom.de>



More information about the gerrit-log mailing list