[MERGED] osmo-iuh[master]: hnbgw: use proper VTY port number defined in libosmocore (4261)

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

Neels Hofmeyr gerrit-no-reply at lists.osmocom.org
Wed Dec 20 13:57:54 UTC 2017


Neels Hofmeyr has submitted this change and it was merged.

Change subject: hnbgw: use proper VTY port number defined in libosmocore (4261)
......................................................................


hnbgw: use proper VTY port number defined in libosmocore (4261)

We used to have hardcoded 2323 from early development, use the proper
libosmocore definition instead.

Depends: Ife52a968a41cb286f640006587877971ff66c1a4 (libosmocore)
Change-Id: Id67d89695ebdc6288f507338c15ad773b8adf6e4
---
M src/hnbgw.c
1 file changed, 2 insertions(+), 1 deletion(-)

Approvals:
  Neels Hofmeyr: Looks good to me, approved
  Jenkins Builder: Verified



diff --git a/src/hnbgw.c b/src/hnbgw.c
index c1b931c..45a753f 100644
--- a/src/hnbgw.c
+++ b/src/hnbgw.c
@@ -45,6 +45,7 @@
 #include <osmocom/vty/telnet_interface.h>
 #include <osmocom/vty/logging.h>
 #include <osmocom/vty/command.h>
+#include <osmocom/vty/ports.h>
 
 #include <osmocom/netif/stream.h>
 
@@ -470,7 +471,7 @@
 		log_set_log_level(osmo_stderr_target,
 				  hnbgw_cmdline_config.log_level);
 
-	rc = telnet_init_dynif(NULL, g_hnb_gw, vty_get_bind_addr(), 2323);
+	rc = telnet_init_dynif(NULL, g_hnb_gw, vty_get_bind_addr(), OSMO_VTY_PORT_HNBGW);
 	if (rc < 0) {
 		perror("Error binding VTY port");
 		exit(1);

-- 
To view, visit https://gerrit.osmocom.org/5521
To unsubscribe, visit https://gerrit.osmocom.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: Id67d89695ebdc6288f507338c15ad773b8adf6e4
Gerrit-PatchSet: 4
Gerrit-Project: osmo-iuh
Gerrit-Branch: master
Gerrit-Owner: Neels Hofmeyr <nhofmeyr at sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: Neels Hofmeyr <nhofmeyr at sysmocom.de>



More information about the gerrit-log mailing list