python/osmo-python-tests[master]: fix osmo_interact_* and osmo_verify_transcript_* after dir s...

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

Max gerrit-no-reply at lists.osmocom.org
Tue Dec 19 14:18:58 UTC 2017


Patch Set 1: Code-Review-1

(3 comments)

https://gerrit.osmocom.org/#/c/5492/1/osmopy/__init__.py
File osmopy/__init__.py:

Line 2: __version__ = '0.0.5'
Please bump the version to avoid confusion


https://gerrit.osmocom.org/#/c/5492/1/osmopy/osmo_interact/ctrl.py
File osmopy/osmo_interact/ctrl.py:

Line 101: def main_verify_transcript_ctrl():
Why this is here and not in actual script?


https://gerrit.osmocom.org/#/c/5492/1/scripts/osmo_interact_ctrl.py
File scripts/osmo_interact_ctrl.py:

Line 23: main_interact_ctrl()
Why not just use the function body directly? Is it used someplace else as well?


-- 
To view, visit https://gerrit.osmocom.org/5492
To unsubscribe, visit https://gerrit.osmocom.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I40a37b212274cb70ebb1e1d9d1b3743eb2d64d05
Gerrit-PatchSet: 1
Gerrit-Project: python/osmo-python-tests
Gerrit-Branch: master
Gerrit-Owner: Neels Hofmeyr <nhofmeyr at sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: Max <msuraev at sysmocom.de>
Gerrit-HasComments: Yes



More information about the gerrit-log mailing list