osmo-iuh[master]: iu client: store multiple LAC, RAC per RNC = fix paging for m...

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

Neels Hofmeyr gerrit-no-reply at lists.osmocom.org
Mon Dec 18 15:58:23 UTC 2017


Patch Set 1: Code-Review-1

(2 comments)

Let me revisit this one; VTY and cleanup extensions might go in separate patch submissions...

https://gerrit.osmocom.org/#/c/5381/1/src/iu_client.c
File src/iu_client.c:

Line 182: 		llist_for_each_entry(e, &rnc->lac_rac_list, entry) {
> we typically introduce a helper function for the look-up.  You have this in
ack


Line 195: 		llist_add(&e->entry, &rnc->lac_rac_list);
> so we always keep adding RAC+LAC to the list but don't ever remove them.  T
my idea was that the effort to save LACs for an RNC Id is far less than placing more hNodeBs to attach to the HNBGW... but agreed, there should be *some* way to get rid of them.

About re-attaching a LAC to another HNBGW, gotcha, I think I'm not handling that one properly.


-- 
To view, visit https://gerrit.osmocom.org/5381
To unsubscribe, visit https://gerrit.osmocom.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I189f8e2663353276b1c615d2f78455dafe568045
Gerrit-PatchSet: 1
Gerrit-Project: osmo-iuh
Gerrit-Branch: master
Gerrit-Owner: Neels Hofmeyr <nhofmeyr at sysmocom.de>
Gerrit-Reviewer: Harald Welte <laforge at gnumonks.org>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: Neels Hofmeyr <nhofmeyr at sysmocom.de>
Gerrit-HasComments: Yes



More information about the gerrit-log mailing list