[PATCH] libosmocore[master]: ctrl_test: add two more current parsing bugs to prep for fix

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

Neels Hofmeyr gerrit-no-reply at lists.osmocom.org
Mon Dec 18 03:39:22 UTC 2017


Hello Harald Welte, Jenkins Builder,

I'd like you to reexamine a change.  Please visit

    https://gerrit.osmocom.org/5435

to look at the new patch set (#4).

ctrl_test: add two more current parsing bugs to prep for fix

Change-Id: Id11bc326be2f0bc2746a928354e416495a18baf7
---
M tests/ctrl/ctrl_test.c
M tests/ctrl/ctrl_test.ok
2 files changed, 34 insertions(+), 0 deletions(-)


  git pull ssh://gerrit.osmocom.org:29418/libosmocore refs/changes/35/5435/4

diff --git a/tests/ctrl/ctrl_test.c b/tests/ctrl/ctrl_test.c
index e25929c..b1d4f23 100644
--- a/tests/ctrl/ctrl_test.c
+++ b/tests/ctrl/ctrl_test.c
@@ -154,6 +154,22 @@
 		"ERROR 1 Command not found",
 
 	},
+	{ "GET 1 var\ti\table",
+		{
+			.type = CTRL_TYPE_GET,
+			.id = "1",
+			.variable = "var\ti\table", /* current bug */
+		},
+		"ERROR 1 Command not found",
+	},
+	{ "GET 1 var\ri\rable",
+		{
+			.type = CTRL_TYPE_GET,
+			.id = "1",
+			.variable = "var\ri\rable", /* current bug */
+		},
+		"ERROR 1 Command not found",
+	},
 	{ "GET 1 variable value",
 		{
 			.type = CTRL_TYPE_GET,
diff --git a/tests/ctrl/ctrl_test.ok b/tests/ctrl/ctrl_test.ok
index 210c599..4a3a169 100644
--- a/tests/ctrl/ctrl_test.ok
+++ b/tests/ctrl/ctrl_test.ok
@@ -34,6 +34,24 @@
 handling:
 replied: 'ERROR 1 Command not found'
 ok
+test: 'GET 1 var\ti\table'
+parsing:
+id = '1'
+variable = 'var\ti\table'
+value = '(null)'
+reply = '(null)'
+handling:
+replied: 'ERROR 1 Command not found'
+ok
+test: 'GET 1 var\ri\rable'
+parsing:
+id = '1'
+variable = 'var\ri\rable'
+value = '(null)'
+reply = '(null)'
+handling:
+replied: 'ERROR 1 Command not found'
+ok
 test: 'GET 1 variable value'
 parsing:
 id = '1'

-- 
To view, visit https://gerrit.osmocom.org/5435
To unsubscribe, visit https://gerrit.osmocom.org/settings

Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Id11bc326be2f0bc2746a928354e416495a18baf7
Gerrit-PatchSet: 4
Gerrit-Project: libosmocore
Gerrit-Branch: master
Gerrit-Owner: Neels Hofmeyr <nhofmeyr at sysmocom.de>
Gerrit-Reviewer: Harald Welte <laforge at gnumonks.org>
Gerrit-Reviewer: Jenkins Builder



More information about the gerrit-log mailing list