[PATCH] libosmocore[master]: ctrl_test: show memleak when receiving GET_REPLY and SET_REP...

[Neels Hofmeyr]

Hello Jenkins Builder,

I'd like you to reexamine a change.  Please visit

    https://gerrit.osmocom.org/5433

to look at the new patch set (#4).

ctrl_test: show memleak when receiving GET_REPLY and SET_REPLY commands

The "memleak!" output shows messages that lack a talloc_free() of the parsed
ctrl command buffer. The leak shall be fixed in a subsequent patch.

Change-Id: I2c3e4d08b769b9cd77593362ea36a28d681cd042
---
M tests/ctrl/ctrl_test.c
M tests/ctrl/ctrl_test.ok
2 files changed, 40 insertions(+), 2 deletions(-)


  git pull ssh://gerrit.osmocom.org:29418/libosmocore refs/changes/33/5433/4

diff --git a/tests/ctrl/ctrl_test.c b/tests/ctrl/ctrl_test.c
index b3fa05e..9c7316f 100644
--- a/tests/ctrl/ctrl_test.c
+++ b/tests/ctrl/ctrl_test.c
@@ -120,8 +120,9 @@
 
 	if (talloc_total_size(ctx) != ctx_size_was) {
 		printf("mem leak!\n");
-		talloc_report_full(ctx, stdout);
-		OSMO_ASSERT(false);
+		// hide mem leak to be fixed in subsequent patch
+		//talloc_report_full(ctx, stdout);
+		//OSMO_ASSERT(false);
 	}
 
 	printf("ok\n");
@@ -294,6 +295,25 @@
 		"ERROR \t Command not found",
 
 	},
+	{ "GET_REPLY 1 variable OK",
+		{
+			.type = CTRL_TYPE_GET_REPLY,
+			.id = "1",
+			.variable = "variable",
+			.reply = "OK",
+		},
+		.reply_str = NULL,
+	},
+	{ "SET_REPLY 1 variable OK",
+		{
+			.type = CTRL_TYPE_SET_REPLY,
+			.id = "1",
+			.variable = "variable",
+			.reply = "OK",
+		},
+		.reply_str = NULL,
+	},
+
 };
 
 static void test_messages()
diff --git a/tests/ctrl/ctrl_test.ok b/tests/ctrl/ctrl_test.ok
index edf97ea..9ddcfdb 100644
--- a/tests/ctrl/ctrl_test.ok
+++ b/tests/ctrl/ctrl_test.ok
@@ -160,3 +160,21 @@
 handling:
 replied: 'ERROR \t Command not found'
 ok
+test: 'GET_REPLY 1 variable OK'
+parsing:
+id = '1'
+variable = 'variable'
+value = '(null)'
+reply = 'OK'
+handling:
+mem leak!
+ok
+test: 'SET_REPLY 1 variable OK'
+parsing:
+id = '1'
+variable = 'variable'
+value = '(null)'
+reply = 'OK'
+handling:
+mem leak!
+ok

-- 
To view, visit https://gerrit.osmocom.org/5433
To unsubscribe, visit https://gerrit.osmocom.org/settings

Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I2c3e4d08b769b9cd77593362ea36a28d681cd042
Gerrit-PatchSet: 4
Gerrit-Project: libosmocore
Gerrit-Branch: master
Gerrit-Owner: Neels Hofmeyr <nhofmeyr at sysmocom.de>
Gerrit-Reviewer: Jenkins Builder