[PATCH] osmo-msc[master]: libmsc: a_iface: Remove duplicated 'const' keyword

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

Pau Espin Pedrol gerrit-no-reply at lists.osmocom.org
Fri Dec 15 22:17:20 UTC 2017


Review at  https://gerrit.osmocom.org/5422

libmsc: a_iface: Remove duplicated 'const' keyword

Fixes following compilation warning:
osmo-msc/src/libmsc/a_iface.c:34:0:
osmo-msc/include/osmocom/msc/a_iface.h:60:25: warning: duplicate ‘cons’
declaration specifier [-Wduplicate-decl-specifier]
       int cipher, const const uint8_t *key, int len, int include_imeisv);
                         ^~~~~
osmo-msc/src/libmsc/a_iface.c:167:25: warning: duplicate ‘const’ declaration
specifier [-Wduplicate-decl-specifier]
       int cipher, const const uint8_t *key, int len, int include_imeisv)
                         ^~~~~

Change-Id: I2ce27fcaad07fed7aa926b872f9c7ab638d4f316
---
M include/osmocom/msc/a_iface.h
M src/libmsc/a_iface.c
2 files changed, 2 insertions(+), 2 deletions(-)


  git pull ssh://gerrit.osmocom.org:29418/osmo-msc refs/changes/22/5422/1

diff --git a/include/osmocom/msc/a_iface.h b/include/osmocom/msc/a_iface.h
index 40ad9c8..f0da248 100644
--- a/include/osmocom/msc/a_iface.h
+++ b/include/osmocom/msc/a_iface.h
@@ -57,7 +57,7 @@
 
 /* Send Cipher mode command via A-interface */
 int a_iface_tx_cipher_mode(const struct gsm_subscriber_connection *conn,
-			   int cipher, const const uint8_t *key, int len, int include_imeisv);
+			   int cipher, const uint8_t *key, int len, int include_imeisv);
 
 /* Page a subscriber via A-interface */
 int a_iface_tx_paging(const char *imsi, uint32_t tmsi, uint16_t lac);
diff --git a/src/libmsc/a_iface.c b/src/libmsc/a_iface.c
index bdfef87..83ec82f 100644
--- a/src/libmsc/a_iface.c
+++ b/src/libmsc/a_iface.c
@@ -164,7 +164,7 @@
 
 /* Send Cipher mode command via A-interface */
 int a_iface_tx_cipher_mode(const struct gsm_subscriber_connection *conn,
-			   int cipher, const const uint8_t *key, int len, int include_imeisv)
+			   int cipher, const uint8_t *key, int len, int include_imeisv)
 {
 	/* TODO generalize for A- and Iu interfaces, don't name after 08.08 */
 	struct msgb *msg_resp;

-- 
To view, visit https://gerrit.osmocom.org/5422
To unsubscribe, visit https://gerrit.osmocom.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I2ce27fcaad07fed7aa926b872f9c7ab638d4f316
Gerrit-PatchSet: 1
Gerrit-Project: osmo-msc
Gerrit-Branch: master
Gerrit-Owner: Pau Espin Pedrol <pespin at sysmocom.de>



More information about the gerrit-log mailing list