[MERGED] osmo-pcu[master]: TBF: remove unused variable

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

Max gerrit-no-reply at lists.osmocom.org
Fri Dec 15 16:46:20 UTC 2017


Max has submitted this change and it was merged.

Change subject: TBF: remove unused variable
......................................................................


TBF: remove unused variable

The num_T_exp is write-only so it can be safely dropped.

Change-Id: I94d83ca8c9b2f0732b53fdf42b17ba93cd7f1c15
---
M src/tbf.cpp
M src/tbf.h
2 files changed, 0 insertions(+), 5 deletions(-)

Approvals:
  Harald Welte: Looks good to me, approved
  Jenkins Builder: Verified



diff --git a/src/tbf.cpp b/src/tbf.cpp
index 98005dc..c139af7 100644
--- a/src/tbf.cpp
+++ b/src/tbf.cpp
@@ -162,7 +162,6 @@
 	poll_ts(0),
 	n3105(0),
 	T(0),
-	num_T_exp(0),
 	fT(0),
 	num_fT_exp(0),
 	state(GPRS_RLCMAC_NULL),
@@ -541,7 +540,6 @@
 	LOGPC(DRLCMAC, (T != tbf->T) ? LOGL_ERROR : LOGL_DEBUG, "\n");
 
 	tbf->T = T;
-	tbf->num_T_exp = 0;
 
 	/* Tunning timers can be safely re-scheduled. */
 	tbf->timer.data = tbf;
@@ -1006,8 +1004,6 @@
 {
 	LOGP(DRLCMAC, LOGL_DEBUG, "%s timer %u expired.\n",
 		tbf_name(this), T);
-
-	num_T_exp++;
 
 	switch (T) {
 	case 0: /* assignment */
diff --git a/src/tbf.h b/src/tbf.h
index 558bd21..518bd9b 100644
--- a/src/tbf.h
+++ b/src/tbf.h
@@ -246,7 +246,6 @@
 
 	struct osmo_timer_list	timer;
 	unsigned int T; /* Txxxx number */
-	unsigned int num_T_exp; /* number of consecutive T expirations */
 	
 	struct osmo_gsm_timer_list	gsm_timer;
 	unsigned int fT; /* fTxxxx number */

-- 
To view, visit https://gerrit.osmocom.org/5219
To unsubscribe, visit https://gerrit.osmocom.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I94d83ca8c9b2f0732b53fdf42b17ba93cd7f1c15
Gerrit-PatchSet: 4
Gerrit-Project: osmo-pcu
Gerrit-Branch: master
Gerrit-Owner: Max <msuraev at sysmocom.de>
Gerrit-Reviewer: Harald Welte <laforge at gnumonks.org>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: Max <msuraev at sysmocom.de>



More information about the gerrit-log mailing list