This is merely a historical archive of years 2008-2021, before the migration to mailman3.
A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.
Harald Welte gerrit-no-reply at lists.osmocom.orgHarald Welte has submitted this change and it was merged. Change subject: TBF-DL: fix misleading idle time check ...................................................................... TBF-DL: fix misleading idle time check The dl_tbf_idle_msec is uint32_t so it cannot be < 0. Change-Id: Ic88cb4698bcb9be52a5179529f81b8728bf4f93f --- M src/tbf_dl.cpp 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Harald Welte: Looks good to me, approved Jenkins Builder: Verified diff --git a/src/tbf_dl.cpp b/src/tbf_dl.cpp index 73708f5..4fc60e4 100644 --- a/src/tbf_dl.cpp +++ b/src/tbf_dl.cpp @@ -1252,7 +1252,7 @@ { int keep_time_frames; - if (bts_data()->dl_tbf_idle_msec <= 0) + if (bts_data()->dl_tbf_idle_msec == 0) return false; keep_time_frames = msecs_to_frames(bts_data()->dl_tbf_idle_msec); -- To view, visit https://gerrit.osmocom.org/5218 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ic88cb4698bcb9be52a5179529f81b8728bf4f93f Gerrit-PatchSet: 3 Gerrit-Project: osmo-pcu Gerrit-Branch: master Gerrit-Owner: Max <msuraev at sysmocom.de> Gerrit-Reviewer: Harald Welte <laforge at gnumonks.org> Gerrit-Reviewer: Jenkins Builder