[MERGED] osmo-gsm-tester[master]: bts_osmo: Use correct parameters for create_pcu

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

Pau Espin Pedrol gerrit-no-reply at lists.osmocom.org
Fri Dec 15 10:51:01 UTC 2017


Pau Espin Pedrol has submitted this change and it was merged.

Change subject: bts_osmo: Use correct parameters for create_pcu
......................................................................


bts_osmo: Use correct parameters for create_pcu

Commit c9817a50ff8d4138f9659a4e6e146f9843662af1 moved code from
different BTS into a shared base class, and create_pcu method was
created to be implemented by subclasses to get a new pcu object.
However, parameters where wrongly copied over from pcu() method during
refactoring. create_pcu() has no parameters.

Change-Id: I1e95f2e658a870f86dd9d9d25f446b8efa4107a4
---
M src/osmo_gsm_tester/bts_osmo.py
1 file changed, 1 insertion(+), 1 deletion(-)

Approvals:
  Pau Espin Pedrol: Looks good to me, approved; Verified



diff --git a/src/osmo_gsm_tester/bts_osmo.py b/src/osmo_gsm_tester/bts_osmo.py
index 16e79cf..f4210b8 100644
--- a/src/osmo_gsm_tester/bts_osmo.py
+++ b/src/osmo_gsm_tester/bts_osmo.py
@@ -84,7 +84,7 @@
 
     def pcu(self):
         if self._pcu is None:
-            self._pcu = self.create_pcu(self.suite_run, self, self.conf)
+            self._pcu = self.create_pcu()
         return self._pcu
 
     def set_bsc(self, bsc):

-- 
To view, visit https://gerrit.osmocom.org/5386
To unsubscribe, visit https://gerrit.osmocom.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I1e95f2e658a870f86dd9d9d25f446b8efa4107a4
Gerrit-PatchSet: 1
Gerrit-Project: osmo-gsm-tester
Gerrit-Branch: master
Gerrit-Owner: Pau Espin Pedrol <pespin at sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: Pau Espin Pedrol <pespin at sysmocom.de>



More information about the gerrit-log mailing list