This is merely a historical archive of years 2008-2021, before the migration to mailman3.
A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.
Neels Hofmeyr gerrit-no-reply at lists.osmocom.orgPatch Set 2: > I see no changes in the NITB, why? please read the commit log message. > If this is only used in OsmoHlr incidentally it is, and if osmo_hlr chooses to have proper ctrl commands we could actually drop the mapping to numbers from osmo-gsm-tester. >, I'd prefer having a generic list of algos I first had this in osmo_hlr.py, but we're using the same names in schema.py. I did not want to duplicate the algo strings in schema.py, so wanted a common definition. I didn't want to put enum specific code in schema.py, it should just have the list of names. The most useful place common to schema.py and osmo_hlr.py seems to be util.py. (importing osmo_hlr.py from schema.py is not an option). So I see it as a mapping in util.py that is giving us enum osmo_auth_algo from libosmocore. We happen to need it in current osmo_hlr.py and can also use it to define the algo names in schema.py. A future step if osmo_hlr accepts the names on the ctrl interface will be to drop the mapping to numbers. But what is the proper place to define names available on NITB's and MSC's ctrl interface? I think util.py might still be a good place, short of defining a new libosmocore_defs.py. Do you want me to add a libosmocore_defs.py instead? schema.py? Is it fine as it is? -- To view, visit https://gerrit.osmocom.org/5358 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I7a6ce92468a6ae46136ad4f62381da261fd196c8 Gerrit-PatchSet: 2 Gerrit-Project: osmo-gsm-tester Gerrit-Branch: master Gerrit-Owner: Neels Hofmeyr <nhofmeyr at sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: Neels Hofmeyr <nhofmeyr at sysmocom.de> Gerrit-Reviewer: Pau Espin Pedrol <pespin at sysmocom.de> Gerrit-HasComments: No