[PATCH] osmo-bsc[master]: Add new per-BTS "rsl:unknown" counter to count unknown RSL m...

[Harald Welte]

Review at  https://gerrit.osmocom.org/5352

Add new per-BTS "rsl:unknown" counter to count unknown RSL messages

Change-Id: I268f222140fa5783e1d19f81fbd45614aaa4b8c4
---
M include/osmocom/bsc/gsm_data.h
M src/libbsc/abis_rsl.c
2 files changed, 11 insertions(+), 0 deletions(-)


  git pull ssh://gerrit.osmocom.org:29418/osmo-bsc refs/changes/52/5352/1

diff --git a/include/osmocom/bsc/gsm_data.h b/include/osmocom/bsc/gsm_data.h
index 44fba86..0341138 100644
--- a/include/osmocom/bsc/gsm_data.h
+++ b/include/osmocom/bsc/gsm_data.h
@@ -203,6 +203,7 @@
 	BTS_CTR_PAGING_EXPIRED,
 	BTS_CTR_CHAN_ACT_TOTAL,
 	BTS_CTR_CHAN_ACT_NACK,
+	BTS_CTR_RSL_UNKNOWN,
 };
 
 static const struct rate_ctr_desc bts_ctr_description[] = {
@@ -224,6 +225,7 @@
 	[BTS_CTR_PAGING_EXPIRED] = 		{"paging:expired", "Paging Request expired because of timeout T3113."},
 	[BTS_CTR_CHAN_ACT_TOTAL] =		{"chan_act:total", "Total number of Channel Activations."},
 	[BTS_CTR_CHAN_ACT_NACK] =		{"chan_act:nack", "Number of Channel Activations that the BTS NACKed"},
+	[BTS_CTR_RSL_UNKNOWN] =			{"rsl:unknown", "Number of unknown/unsupported RSL messages received from BTS"},
 };
 
 static const struct rate_ctr_group_desc bts_ctrg_desc = {
diff --git a/src/libbsc/abis_rsl.c b/src/libbsc/abis_rsl.c
index 0f5361e..54e7b82 100644
--- a/src/libbsc/abis_rsl.c
+++ b/src/libbsc/abis_rsl.c
@@ -1667,10 +1667,12 @@
 	case RSL_MT_MR_CODEC_MOD_PER:
 		LOGP(DRSL, LOGL_NOTICE, "%s Unimplemented Abis RSL DChan "
 			"msg 0x%02x\n", ts_name, rslh->c.msg_type);
+		rate_ctr_inc(&sign_link->trx->bts->bts_ctrs->ctr[BTS_CTR_RSL_UNKNOWN]);
 		break;
 	default:
 		LOGP(DRSL, LOGL_NOTICE, "%s unknown Abis RSL DChan msg 0x%02x\n",
 			ts_name, rslh->c.msg_type);
+		rate_ctr_inc(&sign_link->trx->bts->bts_ctrs->ctr[BTS_CTR_RSL_UNKNOWN]);
 		return -EINVAL;
 	}
 
@@ -1724,6 +1726,7 @@
 	default:
 		LOGP(DRSL, LOGL_NOTICE, "%s Unknown Abis RSL TRX message "
 			"type 0x%02x\n", gsm_trx_name(sign_link->trx), rslh->msg_type);
+		rate_ctr_inc(&sign_link->trx->bts->bts_ctrs->ctr[BTS_CTR_RSL_UNKNOWN]);
 		return -EINVAL;
 	}
 	return rc;
@@ -2057,6 +2060,7 @@
 	default:
 		LOGP(DRSL, LOGL_NOTICE, "Unknown Abis RSL TRX message type "
 			"0x%02x\n", rslh->c.msg_type);
+		rate_ctr_inc(&sign_link->trx->bts->bts_ctrs->ctr[BTS_CTR_RSL_UNKNOWN]);
 		return -EINVAL;
 	}
 
@@ -2197,6 +2201,7 @@
 		DEBUGPC(DRLL, "UNKNOWN\n");
 		LOGP(DRLL, LOGL_NOTICE, "unknown Abis RLL message "
 			"type 0x%02x\n", rllh->c.msg_type);
+		rate_ctr_inc(&sign_link->trx->bts->bts_ctrs->ctr[BTS_CTR_RSL_UNKNOWN]);
 	}
 	return rc;
 }
@@ -2564,6 +2569,7 @@
 	default:
 		LOGP(DRSL, LOGL_NOTICE, "Unknown ip.access msg_type 0x%02x\n",
 			rllh->c.msg_type);
+		rate_ctr_inc(&sign_link->trx->bts->bts_ctrs->ctr[BTS_CTR_RSL_UNKNOWN]);
 		break;
 	}
 
@@ -2770,6 +2776,7 @@
 /* Entry-point where L2 RSL from BTS enters */
 int abis_rsl_rcvmsg(struct msgb *msg)
 {
+	struct e1inp_sign_link *sign_link;
 	struct abis_rsl_common_hdr *rslh;
 	int rc = 0;
 
@@ -2784,6 +2791,7 @@
 		return -1;
 	}
 
+	sign_link = msg->dst;
 	rslh = msgb_l2(msg);
 
 	switch (rslh->msg_discr & 0xfe) {
@@ -2809,6 +2817,7 @@
 	default:
 		LOGP(DRSL, LOGL_NOTICE, "unknown RSL message discriminator "
 			"0x%02x\n", rslh->msg_discr);
+		rate_ctr_inc(&sign_link->trx->bts->bts_ctrs->ctr[BTS_CTR_RSL_UNKNOWN]);
 		rc = -EINVAL;
 	}
 	msgb_free(msg);

-- 
To view, visit https://gerrit.osmocom.org/5352
To unsubscribe, visit https://gerrit.osmocom.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I268f222140fa5783e1d19f81fbd45614aaa4b8c4
Gerrit-PatchSet: 1
Gerrit-Project: osmo-bsc
Gerrit-Branch: master
Gerrit-Owner: Harald Welte <laforge at gnumonks.org>