python/osmo-python-tests[master]: Fix python3 compatibility

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

Max gerrit-no-reply at lists.osmocom.org
Wed Dec 13 16:57:44 UTC 2017


Patch Set 1:

> We do not have comprehensive automatic testing of these scripts anywhere

We don't have any testing, that's why I've added basic tests in https://gerrit.osmocom.org/#/c/5277/

> why does this *need* py3 in the first place? "necessary for proper py3 tests" doesn't explain it to me.

If we have code which requires python3 than it have to be tested with python3. But before we commit those we have to first make sure the tests are passed. That's what this patch does.

> Have you *really* tested it and checked the output?

This is completely pointless discussion. The tests have to be run automatically by jenkins for each commit. If you think that the test coverage is insufficient than we have to expand tests first. Either way, https://gerrit.osmocom.org/#/c/5277/ have to be reviewed and merged first.

-- 
To view, visit https://gerrit.osmocom.org/5280
To unsubscribe, visit https://gerrit.osmocom.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ib10dfbec18202245031a634fc3f19677fc952e60
Gerrit-PatchSet: 1
Gerrit-Project: python/osmo-python-tests
Gerrit-Branch: master
Gerrit-Owner: Max <msuraev at sysmocom.de>
Gerrit-Reviewer: Max <msuraev at sysmocom.de>
Gerrit-Reviewer: Neels Hofmeyr <nhofmeyr at sysmocom.de>
Gerrit-Reviewer: Pau Espin Pedrol <pespin at sysmocom.de>
Gerrit-HasComments: No



More information about the gerrit-log mailing list