libosmocore[master]: Fix malformed Abis/RSL messages with extra L3 Information field

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

Pau Espin Pedrol gerrit-no-reply at lists.osmocom.org
Tue Dec 12 08:23:36 UTC 2017


Patch Set 3:

(1 comment)

https://gerrit.osmocom.org/#/c/3258/3/tests/lapd/lapd_test.c
File tests/lapd/lapd_test.c:

Line 365
> Does the above assert hold true now?
It doesn't, as the IE L3 INFO is not added anymore to those messages used here as stated in GSM 08.58 (section 8.3 "Radio link layer management messages"). We actually have no msg->data[6] or 7 or 8 anymore. See how the first ASSERT in the function is changed to verify the IE L3 INFO is not added.


-- 
To view, visit https://gerrit.osmocom.org/3258
To unsubscribe, visit https://gerrit.osmocom.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ibb116214e8b1798d65a8b0917150496a3c14f344
Gerrit-PatchSet: 3
Gerrit-Project: libosmocore
Gerrit-Branch: master
Gerrit-Owner: Harald Welte <laforge at gnumonks.org>
Gerrit-Reviewer: Harald Welte <laforge at gnumonks.org>
Gerrit-Reviewer: Holger Freyther <holger at freyther.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: Max <msuraev at sysmocom.de>
Gerrit-Reviewer: Minh-Quang Nguyen <minh-quang.nguyen at nutaq.com>
Gerrit-Reviewer: Pau Espin Pedrol <pespin at sysmocom.de>
Gerrit-HasComments: Yes



More information about the gerrit-log mailing list