This is merely a historical archive of years 2008-2021, before the migration to mailman3.
A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.
Harald Welte gerrit-no-reply at lists.osmocom.orgHarald Welte has submitted this change and it was merged. Change subject: Allocate SCCP user primitives with headroom ...................................................................... Allocate SCCP user primitives with headroom In I19cb83302aaa404ab1a2d92e6f2aec43d0380426 I set the headroom of msgb's for SCCP User primitives to zero, assuming that we wouldn't need any headroom in those primitives. According to pespin, osmo-msc however needs this headroom: DLSCCP <002e> sccp_user.c:156 Delivering N-CONNECT.indication to SCCP User 'OsmoMSC-A' msgb(0xadfba0): Not enough headroom msgb_push (0 < 264) So let's make sure the new SCCP User primitives are allocated with the same headroom, just like before I19cb83302aaa404ab1a2d92e6f2aec43d0380426. Change-Id: I92d7648f8ffd034341e2f12aa79dd3d16ec3a98d --- M src/sccp_helpers.c 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Harald Welte: Looks good to me, approved Jenkins Builder: Verified diff --git a/src/sccp_helpers.c b/src/sccp_helpers.c index 1a67488..cafca94 100644 --- a/src/sccp_helpers.c +++ b/src/sccp_helpers.c @@ -34,7 +34,7 @@ #include "sccp_internal.h" #define SCU_MSG_SIZE 2048 -#define SCU_MSG_HEADROOM 0 +#define SCU_MSG_HEADROOM 512 static struct msgb *scu_msgb_alloc(const char *name) { -- To view, visit https://gerrit.osmocom.org/5267 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I92d7648f8ffd034341e2f12aa79dd3d16ec3a98d Gerrit-PatchSet: 1 Gerrit-Project: libosmo-sccp Gerrit-Branch: master Gerrit-Owner: Harald Welte <laforge at gnumonks.org> Gerrit-Reviewer: Harald Welte <laforge at gnumonks.org> Gerrit-Reviewer: Jenkins Builder