[MERGED] libosmocore[master]: VTY reference: do not list empty nodes

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

Harald Welte gerrit-no-reply at lists.osmocom.org
Sun Dec 10 13:34:38 UTC 2017


Harald Welte has submitted this change and it was merged.

Change subject: VTY reference: do not list empty nodes
......................................................................


VTY reference: do not list empty nodes

In 'show online-help' output, don't list nodes that have no commands (the
'Password' node).

Change-Id: I3bd6883a87b8b893e560ceadfffbf41bc380109c
---
M src/vty/command.c
1 file changed, 2 insertions(+), 0 deletions(-)

Approvals:
  Harald Welte: Looks good to me, approved
  Jenkins Builder: Verified



diff --git a/src/vty/command.c b/src/vty/command.c
index e5efad2..7395711 100644
--- a/src/vty/command.c
+++ b/src/vty/command.c
@@ -685,6 +685,8 @@
 		cnode = vector_slot(cmdvec, i);
 		if (!cnode)
 			continue;
+		if (vector_active(cnode->cmd_vector) < 1)
+			continue;
 
 		/* De-dup node IDs: how many times has this same name been used before? Count the first
 		 * occurence as _1 and omit that first suffix, so that the first occurence is called

-- 
To view, visit https://gerrit.osmocom.org/5247
To unsubscribe, visit https://gerrit.osmocom.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I3bd6883a87b8b893e560ceadfffbf41bc380109c
Gerrit-PatchSet: 2
Gerrit-Project: libosmocore
Gerrit-Branch: master
Gerrit-Owner: Neels Hofmeyr <nhofmeyr at sysmocom.de>
Gerrit-Reviewer: Harald Welte <laforge at gnumonks.org>
Gerrit-Reviewer: Jenkins Builder



More information about the gerrit-log mailing list