This is merely a historical archive of years 2008-2021, before the migration to mailman3.
A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.
Vadim Yanitskiy gerrit-no-reply at lists.osmocom.org
Patch Set 2:
(1 comment)
https://gerrit.osmocom.org/#/c/5214/2/tests/ecu_fr/ecu_fr_test.c
File tests/ecu_fr/ecu_fr_test.c:
PS2, Line 1: #include <stdint.h>
: #include <unistd.h>
: #include <stdlib.h>
: #include <errno.h>
: #include <getopt.h>
: #include <limits.h>
: #include <sched.h>
: #include <sys/signal.h>
: #include <sys/types.h>
: #include <sys/stat.h>
: #include <sys/ioctl.h>
:
: #include <netinet/in.h>
: #include <arpa/inet.h>
: #include <net/if.h>
:
: #include <osmocom/core/talloc.h>
: #include <osmocom/core/application.h>
: #include <osmocom/vty/telnet_interface.h>
: #include <osmocom/vty/logging.h>
:
: #include <osmo-bts/gsm_data.h>
: #include <osmo-bts/logging.h>
: #include <osmo-bts/ecu_fr.h>
So many useless includes... The following set would be enough:
#include <stdio.h>
#include <stdint.h>
#include <string.h>
#include <osmocom/core/application.h>
#include <osmocom/core/talloc.h>
#include <osmo-bts/gsm_data.h>
#include <osmo-bts/logging.h>
#include <osmo-bts/ecu_fr.h>
--
To view, visit https://gerrit.osmocom.org/5214
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Iae9e69a9578ae305bca42f834694af96a29084e6
Gerrit-PatchSet: 2
Gerrit-Project: osmo-bts
Gerrit-Branch: master
Gerrit-Owner: dexter <pmaier at sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: Neels Hofmeyr <nhofmeyr at sysmocom.de>
Gerrit-Reviewer: Vadim Yanitskiy <axilirator at gmail.com>
Gerrit-HasComments: Yes