This is merely a historical archive of years 2008-2021, before the migration to mailman3.
A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.
Neels Hofmeyr gerrit-no-reply at lists.osmocom.orgPatch Set 1: Code-Review-1 (12 comments) mostly just a bunch of less important cosmetic comments, but one -1 near the end https://gerrit.osmocom.org/#/c/5214/1//COMMIT_MSG Commit Message: Line 10: ith a slince frame. This may cause unpleasant audio effects. ith slince? Line 12: Add a function to craft a replacement frame from the last ideally name the function Line 13: known good frame. Add ecu_fr_test. https://gerrit.osmocom.org/#/c/5214/1/include/osmo-bts/ecu_fr.h File include/osmo-bts/ecu_fr.h: Line 19: */ (usually no license header in .h files, but a short summary would be nice) https://gerrit.osmocom.org/#/c/5214/1/include/osmo-bts/gsm_data_shared.h File include/osmo-bts/gsm_data_shared.h: Line 19: #include <osmocom/gsm/protocol/gsm_12_21.h> (unrelated ws) https://gerrit.osmocom.org/#/c/5214/1/src/common/ecu_fr.c File src/common/ecu_fr.c: Line 1: /* (C) 2017 by sysmocom s.f.m.c. GmbH from Harald's recent comment we should put a dash before s.f.m.c. Line 303: /* Helper function to reduce the XMAXC field. When the XMAXC field reaches (almost any API is a "helper function" :) -- just say what it does, same below) Line 364: LOGP(DL1P, LOGL_ERROR, "Wrong number of bits unpacked!\n"); a bit more context, like at least say we failed to unpack an FR frame Line 377: goto abort; semantically it's not an abort, right? Line 383: goto abort; -1: unreachable code, the goto is not useful anyhow Line 384: LOGP(DL1P, LOGL_ERROR, "Wrong number of bits packed!\n"); context https://gerrit.osmocom.org/#/c/5214/1/src/osmo-bts-trx/scheduler_trx.c File src/osmo-bts-trx/scheduler_trx.c: Line 1113: if (bfi_flag == false && tch_mode == GSM48_CMODE_SPEECH_V1) if (!bfi_flag... -- To view, visit https://gerrit.osmocom.org/5214 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Iae9e69a9578ae305bca42f834694af96a29084e6 Gerrit-PatchSet: 1 Gerrit-Project: osmo-bts Gerrit-Branch: master Gerrit-Owner: dexter <pmaier at sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: Neels Hofmeyr <nhofmeyr at sysmocom.de> Gerrit-HasComments: Yes