osmo-msc[master]: sms db: don't attempt to query pending SMS for unset MSISDN

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

Harald Welte gerrit-no-reply at lists.osmocom.org
Tue Dec 5 17:27:56 UTC 2017


Patch Set 1: Code-Review+2

(1 comment)

https://gerrit.osmocom.org/#/c/5183/1/src/libmsc/db.c
File src/libmsc/db.c:

Line 844: 	if (*vsub->msisdn == '\0')
I would have thought "strlen(vsub->msisdn) == 0" is more readble, but anyway, we an expect people to know how C strings work ;)


-- 
To view, visit https://gerrit.osmocom.org/5183
To unsubscribe, visit https://gerrit.osmocom.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I7d6169d774b2da04b3051957e364fe620feed51e
Gerrit-PatchSet: 1
Gerrit-Project: osmo-msc
Gerrit-Branch: master
Gerrit-Owner: Neels Hofmeyr <nhofmeyr at sysmocom.de>
Gerrit-Reviewer: Harald Welte <laforge at gnumonks.org>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: Max <msuraev at sysmocom.de>
Gerrit-HasComments: Yes



More information about the gerrit-log mailing list