This is merely a historical archive of years 2008-2021, before the migration to mailman3.
A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.
Pau Espin Pedrol gerrit-no-reply at lists.osmocom.orgPatch Set 2: (2 comments) https://gerrit.osmocom.org/#/c/5003/2/src/osmo_gsm_tester/pcu_sysmo.py File src/osmo_gsm_tester/pcu_sysmo.py: Line 49: event_loop.wait(self, self.sysmobts.ready_for_pcu) > expecting this to be part of the test script. We should not make assumption I don't agree here. This is just a workaround for the current implementation as otherwise the process will fail. It's a known issue/limitation and improvement for it is being tracked in a task in redmime. Once osmo-pcu supports re-connecting to osmo-bts if it's not available, then we can drop this code. Test doesn't care about this implementation specific things, let's not add more boilerplate to all test for something which is strictly not needed from tester point of view. Line 84: def _process_remote(self, name, popen_args, remote_cwd=None): > (might make sense to have a common "run on sysmobts" api, but ok since we s I agree that we need to improve the code sharing by using several levels of classes and interfaces, but for now the quick way to add features requires is to do it like this. -- To view, visit https://gerrit.osmocom.org/5003 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I6fbb71df1ad36e5d7eb02f3fdd7987a178d523d3 Gerrit-PatchSet: 2 Gerrit-Project: osmo-gsm-tester Gerrit-Branch: master Gerrit-Owner: Pau Espin Pedrol <pespin at sysmocom.de> Gerrit-Reviewer: Harald Welte <laforge at gnumonks.org> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: Neels Hofmeyr <nhofmeyr at sysmocom.de> Gerrit-Reviewer: Pau Espin Pedrol <pespin at sysmocom.de> Gerrit-HasComments: Yes