osmo-gsm-tester[master]: Add OsmoPcu class

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

Neels Hofmeyr gerrit-no-reply at lists.osmocom.org
Mon Dec 4 17:25:26 UTC 2017


Patch Set 2: Code-Review-1

(1 comment)

https://gerrit.osmocom.org/#/c/5004/2/src/osmo_gsm_tester/pcu_osmo.py
File src/osmo_gsm_tester/pcu_osmo.py:

Line 44:         event_loop.wait(self, self.bts.ready_for_pcu)
> oh, here it is. I'd have expected this in a test script instead.
decided that this is worth a -1.

We should not make assumptions on the scenario that the test scripts want to test. Maybe we want to provoke such "BTS not available" in some test?


-- 
To view, visit https://gerrit.osmocom.org/5004
To unsubscribe, visit https://gerrit.osmocom.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I04d8ed5e02b090d07e91669df44ce354bc6ee749
Gerrit-PatchSet: 2
Gerrit-Project: osmo-gsm-tester
Gerrit-Branch: master
Gerrit-Owner: Pau Espin Pedrol <pespin at sysmocom.de>
Gerrit-Reviewer: Harald Welte <laforge at gnumonks.org>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: Neels Hofmeyr <nhofmeyr at sysmocom.de>
Gerrit-HasComments: Yes



More information about the gerrit-log mailing list