osmo-gsm-tester[master]: Add class OsmoPcuSysmo

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

Neels Hofmeyr gerrit-no-reply at lists.osmocom.org
Mon Dec 4 17:24:41 UTC 2017


Patch Set 2: Code-Review-1

(2 comments)

https://gerrit.osmocom.org/#/c/5003/2/src/osmo_gsm_tester/pcu_sysmo.py
File src/osmo_gsm_tester/pcu_sysmo.py:

Line 49:         event_loop.wait(self, self.sysmobts.ready_for_pcu)
expecting this to be part of the test script. We should not make assumptions on the scenario that the test scripts want to test. Maybe we want to provoke such "BTS not available" in some test?


Line 84:     def _process_remote(self, name, popen_args, remote_cwd=None):
(might make sense to have a common "run on sysmobts" api, but ok since we seem to be going for code dup instead generally)


-- 
To view, visit https://gerrit.osmocom.org/5003
To unsubscribe, visit https://gerrit.osmocom.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I6fbb71df1ad36e5d7eb02f3fdd7987a178d523d3
Gerrit-PatchSet: 2
Gerrit-Project: osmo-gsm-tester
Gerrit-Branch: master
Gerrit-Owner: Pau Espin Pedrol <pespin at sysmocom.de>
Gerrit-Reviewer: Harald Welte <laforge at gnumonks.org>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: Neels Hofmeyr <nhofmeyr at sysmocom.de>
Gerrit-HasComments: Yes



More information about the gerrit-log mailing list