This is merely a historical archive of years 2008-2021, before the migration to mailman3.
A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.
Neels Hofmeyr gerrit-no-reply at lists.osmocom.org
Patch Set 1: Code-Review+2
(2 comments)
https://gerrit.osmocom.org/#/c/5172/1/tests/mgcp/mgcp_test.c
File tests/mgcp/mgcp_test.c:
Line 796: if (msg && strcmp(t->name, "CRCX") == 0) {
lol, didn't even see the missing quotes ... so much for picking too general macro names further above
Line 799: OSMO_ASSERT(rc == 0);
since there's just a single evaluator of rc, I'd have called
OSMO_ASSERT(get_conn_id...() == 0);
directly, but whatever
--
To view, visit https://gerrit.osmocom.org/5172
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: If4f3ed2c3572da196160569a9705b7a302b700a9
Gerrit-PatchSet: 1
Gerrit-Project: osmo-mgw
Gerrit-Branch: master
Gerrit-Owner: dexter <pmaier at sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: Neels Hofmeyr <nhofmeyr at sysmocom.de>
Gerrit-HasComments: Yes