osmo-msc[master]: Add missing CFLAGS

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

Alexander Huemer gerrit-no-reply at lists.osmocom.org
Sun Dec 3 19:10:12 UTC 2017


Patch Set 1:

(2 comments)

> (2 comments)

https://gerrit.osmocom.org/#/c/5138/1/src/utils/Makefile.am
File src/utils/Makefile.am:

Line 12: 	$(LIBOSMOSCCP_CFLAGS) \
> which of the utilities needs SCCP?
Correct, this is unneeded, I'll fix and resubmit.


Line 127: 	$(LIBOSMOSCCP_CFLAGS) \
> for sure, meas_json doesn't need SCCP or MGCP, this is wrong.
That's an indirect dependency via osmocom/msc/gsm_data.h.
Without those CFLAGS the build (with previously described setup) fails with:

  CC       meas_json-meas_json.o
In file included from meas_json.c:40:0:
../../include/osmocom/msc/gsm_data.h:15:10: fatal error: osmocom/sigtran/sccp_sap.h: No such file or directory
 #include <osmocom/sigtran/sccp_sap.h>
          ^~~~~~~~~~~~~~~~~~~~~~~~~~~~
compilation terminated.

or:

  CC       meas_json-meas_json.o
In file included from meas_json.c:40:0:
../../include/osmocom/msc/gsm_data.h:19:10: fatal error: osmocom/mgcp_client/mgcp_client.h: No such file or directory
 #include <osmocom/mgcp_client/mgcp_client.h>
          ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
compilation terminated.


-- 
To view, visit https://gerrit.osmocom.org/5138
To unsubscribe, visit https://gerrit.osmocom.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I67b5d797a80b55e01dcdbb8c782748b049cf9199
Gerrit-PatchSet: 1
Gerrit-Project: osmo-msc
Gerrit-Branch: master
Gerrit-Owner: Alexander Huemer <alexander.huemer at xx.vu>
Gerrit-Reviewer: Alexander Huemer <alexander.huemer at xx.vu>
Gerrit-Reviewer: Harald Welte <laforge at gnumonks.org>
Gerrit-Reviewer: Jenkins Builder
Gerrit-HasComments: Yes



More information about the gerrit-log mailing list