This is merely a historical archive of years 2008-2021, before the migration to mailman3.
A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.
Neels Hofmeyr gerrit-no-reply at lists.osmocom.orgPatch Set 1: Code-Review-1 (8 comments) just -1ing to indicate that there are comments... nothing critical. https://gerrit.osmocom.org/#/c/5125/1/src/common/scheduler.c File src/common/scheduler.c: Line 308: "Prim %u for is out of range (100), or channel %s with " I guess drop 'for' Line 329: LOGL1S(DL1P, LOGL_ERROR, l1t, tn, chan, fn, "Prim has wrong chan_nr=%02x link_id=%02x, " maybe log prim_fn like above? I might be mistaken, am confused by prim_fn vs. fn... https://gerrit.osmocom.org/#/c/5125/1/src/osmo-bts-trx/scheduler_trx.c File src/osmo-bts-trx/scheduler_trx.c: Line 173: LOGL1S(DL1C, LOGL_INFO, l1t, tn, chan, fn, "No prim for transmit.\n"); "to transmit"? Line 266: LOGL1S(DL1C, LOGL_INFO, l1t, tn, chan, fn, "No prim for transmit.\n"); "to transmit" Line 294: LOGL1S(DL1C, LOGL_FATAL, l1t, tn, chan, fn, "Prim invalid length, please FIX! " ("has invalid length"?) Line 393: LOGL1S(DL1C, LOGL_ERROR, l1t, tn, chan, fn,"TCH mode invalid, please fix!\n"); (space after comma) Line 571: LOGL1S(DL1C, LOGL_INFO, l1t, tn, chan, fn, "No TCH or FACCH prim for transmit.\n"); to Line 664: LOGL1S(DL1C, LOGL_INFO, l1t, tn, chan, fn, "No TCH or FACCH prim for transmit.\n"); hmm there seems to be a scheme here. It is "for transmission" or "to transmit" ... admittedly not that awfully important either. -- To view, visit https://gerrit.osmocom.org/5125 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I5703b46c8a59fe00a3cdc063bcf72872980ec5e5 Gerrit-PatchSet: 1 Gerrit-Project: osmo-bts Gerrit-Branch: master Gerrit-Owner: Harald Welte <laforge at gnumonks.org> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: Neels Hofmeyr <nhofmeyr at sysmocom.de> Gerrit-HasComments: Yes