[MERGED] osmocom-bb[master]: mobile: ms->shutdown was not converted properly to enum

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

Holger Freyther gerrit-no-reply at lists.osmocom.org
Fri Dec 1 01:57:31 UTC 2017


Holger Freyther has submitted this change and it was merged.

Change subject: mobile: ms->shutdown was not converted properly to enum
......................................................................


mobile: ms->shutdown was not converted properly to enum

ms->shutdown is ms->shutdown != 0 which should have been
converted to ms->shutdown != MS_SHUTDOWN_NONE. This is fixing
sending SMS.

This was introduced in Iee1140e4848923c7270495c381bf87b7e3fddee1.

Change-Id: Ia74374dd9c0dd0ba9cf5725d66f4d2f2a2cfe9ef
---
M src/host/layer23/src/mobile/gsm411_sms.c
1 file changed, 1 insertion(+), 1 deletion(-)

Approvals:
  Neels Hofmeyr: Looks good to me, approved
  Jenkins Builder: Verified



diff --git a/src/host/layer23/src/mobile/gsm411_sms.c b/src/host/layer23/src/mobile/gsm411_sms.c
index 73fad84..f09d7a1 100644
--- a/src/host/layer23/src/mobile/gsm411_sms.c
+++ b/src/host/layer23/src/mobile/gsm411_sms.c
@@ -632,7 +632,7 @@
 	LOGP(DLSMS, LOGL_INFO, "..._sms_submit()\n");
 
 	/* no running, no transaction */
-	if (!ms->started || ms->shutdown != MS_SHUTDOWN_COMPL) {
+	if (!ms->started || ms->shutdown != MS_SHUTDOWN_NONE) {
 		LOGP(DLSMS, LOGL_ERROR, "Phone is down\n");
 		gsm411_sms_report(ms, sms, GSM411_RP_CAUSE_MO_TEMP_FAIL);
 		sms_free(sms);

-- 
To view, visit https://gerrit.osmocom.org/5097
To unsubscribe, visit https://gerrit.osmocom.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: Ia74374dd9c0dd0ba9cf5725d66f4d2f2a2cfe9ef
Gerrit-PatchSet: 2
Gerrit-Project: osmocom-bb
Gerrit-Branch: master
Gerrit-Owner: Holger Freyther <holger at freyther.de>
Gerrit-Reviewer: Holger Freyther <holger at freyther.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: Neels Hofmeyr <nhofmeyr at sysmocom.de>



More information about the gerrit-log mailing list