[MERGED] osmo-msc[master]: utils: smpp_mirror: temporarily munch SMPP delivery receipts

[Neels Hofmeyr]

Neels Hofmeyr has submitted this change and it was merged.

Change subject: utils: smpp_mirror: temporarily munch SMPP delivery receipts
......................................................................


utils: smpp_mirror: temporarily munch SMPP delivery receipts

Just munch and log SMPP delivery receipts by now, don't mirror this, it
is going to break things in openbsc.

Follow up patch removes this and mirrors this SMPP message as a
SUBMIT_SM with esm_class = Delivery Acknowledgement.

Change-Id: I78e93bc4034679e238c8642ccf6a0e844b1d6d8b
---
M src/utils/smpp_mirror.c
1 file changed, 8 insertions(+), 0 deletions(-)

Approvals:
  Neels Hofmeyr: Looks good to me, approved



diff --git a/src/utils/smpp_mirror.c b/src/utils/smpp_mirror.c
index ec28f0a..edb40b5 100644
--- a/src/utils/smpp_mirror.c
+++ b/src/utils/smpp_mirror.c
@@ -112,6 +112,14 @@
 
 	PACK_AND_SEND(esme, &deliver_r);
 
+	/* This is a delivery receipt, temporarily munch it until we teach
+	 * openbsc what to do with this.
+	 */
+	if (deliver.esm_class == 0x04) {
+		LOGP(DSMPP, LOGL_NOTICE, "%s\n", deliver.short_message);
+		return 0;
+	}
+
 	memset(&submit, 0, sizeof(submit));
 	submit.command_id = SUBMIT_SM;
 	submit.command_status = ESME_ROK;

-- 
To view, visit https://gerrit.osmocom.org/3644
To unsubscribe, visit https://gerrit.osmocom.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I78e93bc4034679e238c8642ccf6a0e844b1d6d8b
Gerrit-PatchSet: 2
Gerrit-Project: osmo-msc
Gerrit-Branch: master
Gerrit-Owner: Neels Hofmeyr <nhofmeyr at sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: Neels Hofmeyr <nhofmeyr at sysmocom.de>
Gerrit-Reviewer: Pablo Neira Ayuso <pablo at gnumonks.org>