[PATCH] libosmocore[master]: cosmetic: umts aka: tweak comments for sqn and ind

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

Neels Hofmeyr gerrit-no-reply at lists.osmocom.org
Sat Aug 26 21:33:11 UTC 2017


Review at  https://gerrit.osmocom.org/3703

cosmetic: umts aka: tweak comments for sqn and ind

Clearly indicate that 'sqn' is an in *and* out-parameter.

Clarify the effect of 'ind'.

Change-Id: Ia40cd4ddf35f4fbe895b45b8ea59378f5ce9eb1f
---
M include/osmocom/crypt/auth.h
1 file changed, 2 insertions(+), 2 deletions(-)


  git pull ssh://gerrit.osmocom.org:29418/libosmocore refs/changes/03/3703/1

diff --git a/include/osmocom/crypt/auth.h b/include/osmocom/crypt/auth.h
index 2f88a3a..059e734 100644
--- a/include/osmocom/crypt/auth.h
+++ b/include/osmocom/crypt/auth.h
@@ -35,10 +35,10 @@
 			uint8_t opc[16]; /*!< operator invariant value */
 			uint8_t k[16];	/*!< secret key of the subscriber */
 			uint8_t amf[2];
-			uint64_t sqn;	/*!< sequence number */
+			uint64_t sqn;	/*!< sequence number (in: prev sqn; out: used sqn) */
 			int opc_is_op;	/*!< is the OPC field OPC (0) or OP (1) ? */
 			unsigned int ind_bitlen; /*!< nr of bits not in SEQ, only SQN */
-			unsigned int ind; /*!< SQN slot, i.e. (SEQ << ind_bitlen) + ind */
+			unsigned int ind; /*!< which IND slot to use an SQN from */
 		} umts;
 		struct {
 			uint8_t ki[16];	/*!< secret key */

-- 
To view, visit https://gerrit.osmocom.org/3703
To unsubscribe, visit https://gerrit.osmocom.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: Ia40cd4ddf35f4fbe895b45b8ea59378f5ce9eb1f
Gerrit-PatchSet: 1
Gerrit-Project: libosmocore
Gerrit-Branch: master
Gerrit-Owner: Neels Hofmeyr <nhofmeyr at sysmocom.de>



More information about the gerrit-log mailing list