[PATCH] osmo-msc[master]: LIBMSC: Use sms->text, not sms->user_data to construct repor...

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

Neels Hofmeyr gerrit-no-reply at lists.osmocom.org
Thu Aug 24 17:41:11 UTC 2017


Review at  https://gerrit.osmocom.org/3666

LIBMSC: Use sms->text, not sms->user_data to construct report body

gsm_04_11.c sms_report_alloc()

Use the sms->text, not the sms->user_data to construct the report body.
This also prevents the potential output of non printable characters to
the log and or vty.

Change-Id: Id51bc9483ad6f52d6da74135605cfd12434c7c96
---
M src/libmsc/gsm_04_11.c
1 file changed, 1 insertion(+), 1 deletion(-)


  git pull ssh://gerrit.osmocom.org:29418/osmo-msc refs/changes/66/3666/1

diff --git a/src/libmsc/gsm_04_11.c b/src/libmsc/gsm_04_11.c
index f87acea..55642aa 100644
--- a/src/libmsc/gsm_04_11.c
+++ b/src/libmsc/gsm_04_11.c
@@ -667,7 +667,7 @@
 	len = snprintf((char *)sms_report->user_data,
 		       sizeof(sms_report->user_data),
 		       "id:%.08llu sub:000 dlvrd:000 submit date:YYMMDDhhmm done date:YYMMDDhhmm stat:DELIVRD err:000 text:%.20s",
-		       sms->id, sms->user_data);
+		       sms->id, sms->text);
 	sms_report->user_data_len = len;
 	LOGP(DLSMS, LOGL_NOTICE, "%s\n", sms_report->user_data);
 

-- 
To view, visit https://gerrit.osmocom.org/3666
To unsubscribe, visit https://gerrit.osmocom.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: Id51bc9483ad6f52d6da74135605cfd12434c7c96
Gerrit-PatchSet: 1
Gerrit-Project: osmo-msc
Gerrit-Branch: master
Gerrit-Owner: Neels Hofmeyr <nhofmeyr at sysmocom.de>
Gerrit-Reviewer: Keith Whyte <keith at rhizomatica.org>



More information about the gerrit-log mailing list