[MERGED] osmo-gsm-tester[master]: nitb: ctrl: Remove unused return statement in subscriber_add

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

Pau Espin Pedrol gerrit-no-reply at lists.osmocom.org
Thu Aug 24 16:39:16 UTC 2017


Pau Espin Pedrol has submitted this change and it was merged.

Change subject: nitb: ctrl: Remove unused return statement in subscriber_add
......................................................................


nitb: ctrl: Remove unused return statement in subscriber_add

In case of failure an exception is raised. If everything goes well no
need to return True.

Change-Id: I5194eeb9208f973da12f2fa710f2b3e7acd78fb5
---
M src/osmo_gsm_tester/osmo_nitb.py
1 file changed, 0 insertions(+), 1 deletion(-)

Approvals:
  Pau Espin Pedrol: Looks good to me, approved
  Jenkins Builder: Verified



diff --git a/src/osmo_gsm_tester/osmo_nitb.py b/src/osmo_gsm_tester/osmo_nitb.py
index 9c15fe6..3b396fa 100644
--- a/src/osmo_gsm_tester/osmo_nitb.py
+++ b/src/osmo_gsm_tester/osmo_nitb.py
@@ -166,7 +166,6 @@
             if not res:
                 raise RuntimeError('Cannot create subscriber %r (answer=%r)' % (imsi, answer_str))
             self.dbg('Created subscriber', imsi=imsi, msisdn=msisdn)
-            return True
 
     def subscriber_list_active(self):
         aslist_str = ""

-- 
To view, visit https://gerrit.osmocom.org/3590
To unsubscribe, visit https://gerrit.osmocom.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I5194eeb9208f973da12f2fa710f2b3e7acd78fb5
Gerrit-PatchSet: 1
Gerrit-Project: osmo-gsm-tester
Gerrit-Branch: master
Gerrit-Owner: Pau Espin Pedrol <pespin at sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: Pau Espin Pedrol <pespin at sysmocom.de>
Gerrit-Reviewer: neels <nhofmeyr at sysmocom.de>



More information about the gerrit-log mailing list