[PATCH] osmo-bts[master]: osmo-bts-trx: Relax validation to allow TRX data bursts with...

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

Pau Espin Pedrol gerrit-no-reply at lists.osmocom.org
Tue Aug 22 13:36:55 UTC 2017


Review at  https://gerrit.osmocom.org/3580

osmo-bts-trx: Relax validation to allow TRX data bursts without padding

Original OpenBTS transcievers add 2 bytes of padding to the end of data
bursts, having in total 158 bytes. As those two extra bytes are being
ignored after the initial validation, let's relax this validation a bit
in order to accept transcievers that decide no to send these two extra
bytes.

Change-Id: I94c3cb160bfed0ba9c41ed7ef5f8d8a65b81ad07
---
M src/osmo-bts-trx/trx_if.c
1 file changed, 1 insertion(+), 1 deletion(-)


  git pull ssh://gerrit.osmocom.org:29418/osmo-bts refs/changes/80/3580/1

diff --git a/src/osmo-bts-trx/trx_if.c b/src/osmo-bts-trx/trx_if.c
index 86a3b9b..d93d61c 100644
--- a/src/osmo-bts-trx/trx_if.c
+++ b/src/osmo-bts-trx/trx_if.c
@@ -443,7 +443,7 @@
 		return len;
 	} else if (len == EGPRS_BURST_LEN + 10) {
 		burst_len = EGPRS_BURST_LEN;
-	} else if (len != GSM_BURST_LEN + 10) {
+	} else if (len != GSM_BURST_LEN + 10 && len != GSM_BURST_LEN + 8) {
 		LOGP(DTRX, LOGL_NOTICE, "Got data message with invalid lenght "
 			"'%d'\n", len);
 		return -EINVAL;

-- 
To view, visit https://gerrit.osmocom.org/3580
To unsubscribe, visit https://gerrit.osmocom.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I94c3cb160bfed0ba9c41ed7ef5f8d8a65b81ad07
Gerrit-PatchSet: 1
Gerrit-Project: osmo-bts
Gerrit-Branch: master
Gerrit-Owner: Pau Espin Pedrol <pespin at sysmocom.de>



More information about the gerrit-log mailing list