openbsc[master]: Revert "factor out & introduce struct gsm_encr, in common_cs.h"

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

Max gerrit-no-reply at lists.osmocom.org
Mon Aug 21 13:16:30 UTC 2017


Patch Set 1:

(2 comments)

https://gerrit.osmocom.org/#/c/3570/1/openbsc/include/openbsc/gsm_data_shared.h
File openbsc/include/openbsc/gsm_data_shared.h:

Line 132: #define MAX_A5_KEY_LEN	(128/8)
I think it's better to put this next to actual a5 implementation in libosmocore.


Line 235: 		uint8_t alg_id;
Is this enum osmo_auth_algo or smth else?


-- 
To view, visit https://gerrit.osmocom.org/3570
To unsubscribe, visit https://gerrit.osmocom.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I15d60441c6c6f053486c0482258a8759bdd92df1
Gerrit-PatchSet: 1
Gerrit-Project: openbsc
Gerrit-Branch: master
Gerrit-Owner: Neels Hofmeyr <nhofmeyr at sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: Max <msuraev at sysmocom.de>
Gerrit-HasComments: Yes



More information about the gerrit-log mailing list