[MERGED] openbsc[master]: gbproxy: log signal value as text

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

Max gerrit-no-reply at lists.osmocom.org
Fri Aug 18 18:07:37 UTC 2017


Max has submitted this change and it was merged.

Change subject: gbproxy: log signal value as text
......................................................................


gbproxy: log signal value as text

Change-Id: I6ed923f5c60a8d64305f4b8e90d1362d6510e1c5
---
M openbsc/src/gprs/gb_proxy.c
1 file changed, 4 insertions(+), 6 deletions(-)

Approvals:
  Harald Welte: Looks good to me, approved
  Jenkins Builder: Verified



diff --git a/openbsc/src/gprs/gb_proxy.c b/openbsc/src/gprs/gb_proxy.c
index b98a9a5..cd38d23 100644
--- a/openbsc/src/gprs/gb_proxy.c
+++ b/openbsc/src/gprs/gb_proxy.c
@@ -1369,9 +1369,8 @@
 		/* from BSS to SGSN */
 		peer = gbproxy_peer_by_nsei(cfg, nsvc->nsei);
 		if (!peer) {
-			LOGP(DGPRS, LOGL_NOTICE, "signal %u for unknown peer "
-			     "NSEI=%u/NSVCI=%u\n", signal, nsvc->nsei,
-			     nsvc->nsvci);
+			LOGP(DGPRS, LOGL_NOTICE, "signal '%s' for unknown peer NSEI=%u/NSVCI=%u\n",
+			     get_value_string(gprs_ns_signal_ns_names, signal), nsvc->nsei, nsvc->nsvci);
 			return 0;
 		}
 		switch (signal) {
@@ -1379,9 +1378,8 @@
 		case S_NS_BLOCK:
 			if (!peer->blocked)
 				break;
-			LOGP(DGPRS, LOGL_NOTICE, "Converting NS_RESET from "
-			     "NSEI=%u/NSVCI=%u into BSSGP_BVC_BLOCK to SGSN\n",
-			     nsvc->nsei, nsvc->nsvci);
+			LOGP(DGPRS, LOGL_NOTICE, "Converting '%s' from NSEI=%u/NSVCI=%u into BSSGP_BVC_BLOCK to SGSN\n",
+			     get_value_string(gprs_ns_signal_ns_names, signal), nsvc->nsei, nsvc->nsvci);
 			bssgp_tx_simple_bvci(BSSGP_PDUT_BVC_BLOCK, nsvc->nsei,
 					     peer->bvci, 0);
 			break;

-- 
To view, visit https://gerrit.osmocom.org/3556
To unsubscribe, visit https://gerrit.osmocom.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I6ed923f5c60a8d64305f4b8e90d1362d6510e1c5
Gerrit-PatchSet: 3
Gerrit-Project: openbsc
Gerrit-Branch: master
Gerrit-Owner: Max <msuraev at sysmocom.de>
Gerrit-Reviewer: Harald Welte <laforge at gnumonks.org>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: Max <msuraev at sysmocom.de>



More information about the gerrit-log mailing list