[MERGED] libosmocore[master]: gsm0411_utils: GSM03.40 9.2.3.11 SCTS should be local

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

Harald Welte gerrit-no-reply at lists.osmocom.org
Fri Aug 18 18:02:31 UTC 2017


Harald Welte has submitted this change and it was merged.

Change subject: gsm0411_utils: GSM03.40 9.2.3.11 SCTS should be local
......................................................................


gsm0411_utils: GSM03.40 9.2.3.11 SCTS should be local

>From GSM 03.40: "The Service-Centre-Time-Stamp, and any other times
coded in this format that are defined in this specification,
represent the time local to the sending entity."

Change-Id: I4efdb1eaae43aced33961b64d4f14b0040321c10
---
M src/gsm/gsm0411_utils.c
1 file changed, 1 insertion(+), 1 deletion(-)

Approvals:
  Harald Welte: Looks good to me, approved
  Jenkins Builder: Verified
  Pablo Neira Ayuso: Looks good to me, but someone else must approve



diff --git a/src/gsm/gsm0411_utils.c b/src/gsm/gsm0411_utils.c
index 1d3ef49..a4e9d0d 100644
--- a/src/gsm/gsm0411_utils.c
+++ b/src/gsm/gsm0411_utils.c
@@ -89,7 +89,7 @@
  *  \param[in] time to encode */
 void gsm340_gen_scts(uint8_t *scts, time_t time)
 {
-	struct tm *tm = gmtime(&time);
+	struct tm *tm = localtime(&time);
 
 	*scts++ = gsm411_bcdify(tm->tm_year % 100);
 	*scts++ = gsm411_bcdify(tm->tm_mon + 1);

-- 
To view, visit https://gerrit.osmocom.org/3551
To unsubscribe, visit https://gerrit.osmocom.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I4efdb1eaae43aced33961b64d4f14b0040321c10
Gerrit-PatchSet: 1
Gerrit-Project: libosmocore
Gerrit-Branch: master
Gerrit-Owner: Keith Whyte <keith at rhizomatica.org>
Gerrit-Reviewer: Harald Welte <laforge at gnumonks.org>
Gerrit-Reviewer: Holger Freyther <holger at freyther.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: Keith Whyte <keith at rhizomatica.org>
Gerrit-Reviewer: Pablo Neira Ayuso <pablo at gnumonks.org>



More information about the gerrit-log mailing list