[MERGED] osmo-bts[master]: osmo-bts-trx: Enable osmotrx tx-attenuation oml by default

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

Harald Welte gerrit-no-reply at lists.osmocom.org
Tue Aug 15 13:27:27 UTC 2017


Harald Welte has submitted this change and it was merged.

Change subject: osmo-bts-trx: Enable osmotrx tx-attenuation oml by default
......................................................................


osmo-bts-trx: Enable osmotrx tx-attenuation oml by default

There are currently two ways to specify power reductions to be sent to
osmo-trx from osmo-bts-trx:
* osmotrx tx-attenuation oml
* osmotrx tx-attenuation <0-50>

None of them is enabled by default, which means if none of them is
specified in the config file of osmo-bts-trx, SETPOWER cmd won't be sent
to osmo-trx, which in turn won't turn on the transciever.

Let's enable osmo tx-attenuation oml by default and leave it up to the
bsc to decide which power reduction to use. If the user wants to
configure a specific tx-attentuation, it can still do so in exactly the
same way he used to do it.

Change-Id: Ia8640751630ee37e5f5d1f470bad892a08e80654
---
M src/osmo-bts-trx/main.c
1 file changed, 2 insertions(+), 0 deletions(-)

Approvals:
  Harald Welte: Looks good to me, approved
  Jenkins Builder: Verified



diff --git a/src/osmo-bts-trx/main.c b/src/osmo-bts-trx/main.c
index da3dc60..283e549 100644
--- a/src/osmo-bts-trx/main.c
+++ b/src/osmo-bts-trx/main.c
@@ -130,6 +130,8 @@
 	l1h = talloc_zero(tall_bts_ctx, struct trx_l1h);
 	l1h->phy_inst = pinst;
 	pinst->u.osmotrx.hdl = l1h;
+
+	l1h->config.power_oml = 1;
 }
 
 int main(int argc, char **argv)

-- 
To view, visit https://gerrit.osmocom.org/3526
To unsubscribe, visit https://gerrit.osmocom.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: Ia8640751630ee37e5f5d1f470bad892a08e80654
Gerrit-PatchSet: 1
Gerrit-Project: osmo-bts
Gerrit-Branch: master
Gerrit-Owner: Pau Espin Pedrol <pespin at sysmocom.de>
Gerrit-Reviewer: Harald Welte <laforge at gnumonks.org>
Gerrit-Reviewer: Jenkins Builder



More information about the gerrit-log mailing list