openbsc[master]: gsm_04_11: get rid of unused parameter in sms_route_mt_sms()

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

Harald Welte gerrit-no-reply at lists.osmocom.org
Wed Aug 9 09:27:32 UTC 2017


Patch Set 1:

I think particularly if all functions are 'static' and within one file, any reasonably optimizing compiler should remove unused function arguments, so this is a bit of a pseudo-discussion here.

We do have several places in the code where we pass along some objects either to make function signatures similar with other functions, or if we're not sure if we will need it at a not-too-distant point (if we take a short-cut by not checking some things we should check, e.g.).

Summary: I would simply mark the function as static (as in this patch) but not remove unused arguments.  But then, honestly, I don't care.  We can also simply leave it like it is.

-- 
To view, visit https://gerrit.osmocom.org/3422
To unsubscribe, visit https://gerrit.osmocom.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I797abce3f91447e8f397c7cf726db7425479fe0e
Gerrit-PatchSet: 1
Gerrit-Project: openbsc
Gerrit-Branch: master
Gerrit-Owner: Pablo Neira Ayuso <pablo at gnumonks.org>
Gerrit-Reviewer: Harald Welte <laforge at gnumonks.org>
Gerrit-Reviewer: Holger Freyther <holger at freyther.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: Keith Whyte <keith at rhizomatica.org>
Gerrit-Reviewer: Neels Hofmeyr <nhofmeyr at sysmocom.de>
Gerrit-Reviewer: Pablo Neira Ayuso <pablo at gnumonks.org>
Gerrit-HasComments: No



More information about the gerrit-log mailing list