libosmo-sccp[master]: ensure valid primary_pc in osmo_ss7_instance

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

Harald Welte gerrit-no-reply at lists.osmocom.org
Tue Aug 8 18:22:51 UTC 2017


Patch Set 3:

It is likely we will at some point have secondary point codes. Hence, I would prefer to either have a sub-structure that encapsulates the uint32_t and the valid flag, so that type and related code/functions can be re-used (e.g. something like is_pc_valid() inline function that then can operate on that type).

An alternative would be to use the MSB as valid flag, as all known point code formats have a maximum of 24 bits in length.

-- 
To view, visit https://gerrit.osmocom.org/3355
To unsubscribe, visit https://gerrit.osmocom.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I7f0f0c89b7335d9da24161bfac8234be214ca00c
Gerrit-PatchSet: 3
Gerrit-Project: libosmo-sccp
Gerrit-Branch: master
Gerrit-Owner: Neels Hofmeyr <nhofmeyr at sysmocom.de>
Gerrit-Reviewer: Harald Welte <laforge at gnumonks.org>
Gerrit-Reviewer: Jenkins Builder
Gerrit-HasComments: No



More information about the gerrit-log mailing list