[PATCH] libosmo-sccp[master]: introduce OSMO_SCCP_RI_NONE to indicate unset RI

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

Neels Hofmeyr gerrit-no-reply at lists.osmocom.org
Mon Aug 7 14:07:07 UTC 2017


Hello Jenkins Builder,

I'd like you to reexamine a change.  Please visit

    https://gerrit.osmocom.org/3362

to look at the new patch set (#2).

introduce OSMO_SCCP_RI_NONE to indicate unset RI

Allows to automatically set an RI in future change
I75c67d289693f1c2a049ac61cf2b2097d6e5687d
"sccp-addr vty: set RI to SSN_PC when setting a point-code"

Change-Id: I6e2f31b023b08cba2f2ee8234e6108efcaca41c0
---
M include/osmocom/sigtran/sccp_sap.h
M src/osmo_ss7_vty.c
2 files changed, 6 insertions(+), 0 deletions(-)


  git pull ssh://gerrit.osmocom.org:29418/libosmo-sccp refs/changes/62/3362/2

diff --git a/include/osmocom/sigtran/sccp_sap.h b/include/osmocom/sigtran/sccp_sap.h
index 732df2a..ff4c674 100644
--- a/include/osmocom/sigtran/sccp_sap.h
+++ b/include/osmocom/sigtran/sccp_sap.h
@@ -54,6 +54,7 @@
 
 /* Q.713 3.4.1 + RFC 3868 3.10.2.3 */
 enum osmo_sccp_routing_ind {
+	OSMO_SCCP_RI_NONE,
 	OSMO_SCCP_RI_GT,
 	OSMO_SCCP_RI_SSN_PC,
 	OSMO_SCCP_RI_SSN_IP,
diff --git a/src/osmo_ss7_vty.c b/src/osmo_ss7_vty.c
index fab27b4..f60eef4 100644
--- a/src/osmo_ss7_vty.c
+++ b/src/osmo_ss7_vty.c
@@ -1049,6 +1049,11 @@
 		case OSMO_SCCP_RI_SSN_IP:
 			vty_out(vty, "  routing-indicator IP%s", VTY_NEWLINE);
 			break;
+		case OSMO_SCCP_RI_NONE:
+			break;
+		default:
+			vty_out(vty, "  ! invalid routing-indicator value: %u%s", entry->addr.ri, VTY_NEWLINE);
+			break;
 		}
 		if (entry->addr.presence & OSMO_SCCP_ADDR_T_PC)
 			vty_out(vty, "  point-code %s%s",

-- 
To view, visit https://gerrit.osmocom.org/3362
To unsubscribe, visit https://gerrit.osmocom.org/settings

Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I6e2f31b023b08cba2f2ee8234e6108efcaca41c0
Gerrit-PatchSet: 2
Gerrit-Project: libosmo-sccp
Gerrit-Branch: master
Gerrit-Owner: Neels Hofmeyr <nhofmeyr at sysmocom.de>
Gerrit-Reviewer: Jenkins Builder



More information about the gerrit-log mailing list