openbsc[master]: Make BTS type and variant converters shareable

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

Holger Freyther gerrit-no-reply at lists.osmocom.org
Sun Apr 30 21:48:54 UTC 2017


Patch Set 7:

(1 comment)

https://gerrit.osmocom.org/#/c/2286/7/openbsc/src/libcommon/gsm_data_shared.c
File openbsc/src/libcommon/gsm_data_shared.c:

Line 70: const struct value_string bts_variant_names[_NUM_BTS_VARIANT + 1] = {
BikeShedding:

* bts_variant.. they are all osmo-bts variants. Reflect that in the name?
* In fact some of them are not BTS variants but more the Phy. So all of them are osmo-bts but have various limitations/features in the Phy (dual-trx, single-trx, no HR1, higher latency due Ethernet?)

Maybe do it based on features? Have a name enable/unlock features?

So something like.. can_have_multiple_sdcch8, can_be_multi_trx?


-- 
To view, visit https://gerrit.osmocom.org/2286
To unsubscribe, visit https://gerrit.osmocom.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ida94725a6fce968443541e3526f48f13758031fd
Gerrit-PatchSet: 7
Gerrit-Project: openbsc
Gerrit-Branch: master
Gerrit-Owner: Max <msuraev at sysmocom.de>
Gerrit-Reviewer: Harald Welte <laforge at gnumonks.org>
Gerrit-Reviewer: Holger Freyther <holger at freyther.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-HasComments: Yes



More information about the gerrit-log mailing list