libosmocore[master]: Fix wrongful GSM codecs SID frame detection in DTX.

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

Harald Welte gerrit-no-reply at lists.osmocom.org
Fri Apr 28 07:21:29 UTC 2017


Patch Set 1: Code-Review+1

we should introduce a test case at the same time we fix this, just to validate the old code was wrong, the new code works, and that future versions will not introduce regressions.  It should be as straight-forward as to checking against a valid and an invalid FR SID frame from a const uint8_t[] array.  If yo can give me some valid FR SID samples, I'd volunteer to write the test case.

-- 
To view, visit https://gerrit.osmocom.org/2441
To unsubscribe, visit https://gerrit.osmocom.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I45d98c6edf267f313883503a65385190ffbc65ca
Gerrit-PatchSet: 1
Gerrit-Project: libosmocore
Gerrit-Branch: master
Gerrit-Owner: jfdionne <jf.dionne at nutaq.com>
Gerrit-Reviewer: Harald Welte <laforge at gnumonks.org>
Gerrit-Reviewer: Jenkins Builder
Gerrit-HasComments: No



More information about the gerrit-log mailing list