[MERGED] libosmo-sccp[master]: deliver_to_mtp_user(): Fix null pointer dereference

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

Harald Welte gerrit-no-reply at lists.osmocom.org
Thu Apr 27 19:51:01 UTC 2017


Harald Welte has submitted this change and it was merged.

Change subject: deliver_to_mtp_user(): Fix null pointer dereference
......................................................................


deliver_to_mtp_user(): Fix null pointer dereference

We had used + derefernced the 'prim' pointer before checking its
validity.

Change-Id: I0ca5026091e91926924b297f9342bda5f9fd38c9
Fixes: coverity CID#166946
---
M src/osmo_ss7_hmrt.c
1 file changed, 1 insertion(+), 1 deletion(-)

Approvals:
  Harald Welte: Looks good to me, approved
  Jenkins Builder: Verified



diff --git a/src/osmo_ss7_hmrt.c b/src/osmo_ss7_hmrt.c
index bbbb3a9..393530a 100644
--- a/src/osmo_ss7_hmrt.c
+++ b/src/osmo_ss7_hmrt.c
@@ -67,9 +67,9 @@
 
 	/* Create MTP-TRANSFER.ind and feed to user */
 	prim = m3ua_to_xfer_ind(xua);
-	prim->u.transfer = xua->mtp;
 	if (!prim)
 		return -1;
+	prim->u.transfer = xua->mtp;
 
 	return osu->prim_cb(&prim->oph, (void *) osu->priv);
 }

-- 
To view, visit https://gerrit.osmocom.org/2431
To unsubscribe, visit https://gerrit.osmocom.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I0ca5026091e91926924b297f9342bda5f9fd38c9
Gerrit-PatchSet: 1
Gerrit-Project: libosmo-sccp
Gerrit-Branch: master
Gerrit-Owner: Harald Welte <laforge at gnumonks.org>
Gerrit-Reviewer: Harald Welte <laforge at gnumonks.org>
Gerrit-Reviewer: Jenkins Builder



More information about the gerrit-log mailing list